forks
/
D-Scanner
mirror of https://github.com/dlang-community/D-Scanner.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #510 from dlang-community/issue-452 

fix #452 - false pos for naming style of a VariableDecl with the "enum" storage class
This commit is contained in:
Richard Andrew Cattermole 2017-08-12 01:05:10 +12:00 committed by GitHub
parent 0d48f27873 511cee29dc
commit 45563536d1
1 changed files with 5 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
src/analysis/style.d
View File

@ -70,18 +70,12 @@ final class StyleChecker : BaseAnalyzer
override void visit(const VariableDeclaration vd) override void visit(const VariableDeclaration vd)
{ {
import std.algorithm.iteration : filter;
varIsEnum = !vd.storageClasses.filter!(a => a.token == tok!"enum").empty;
vd.accept(this); vd.accept(this);
} }
override void visit(const Declarator dec) override void visit(const Declarator dec)
{ {
if (varIsEnum) checkLowercaseName("Variable", dec.name);
checkAggregateName("Variable", dec.name);
else
checkLowercaseName("Variable", dec.name);
} }
override void visit(const FunctionDeclaration dec) override void visit(const FunctionDeclaration dec)
@ -143,8 +137,6 @@ final class StyleChecker : BaseAnalyzer
aggregateType ~ " name '" ~ name.text ~ "' does not match style guidelines."); aggregateType ~ " name '" ~ name.text ~ "' does not match style guidelines.");
} }
bool varIsEnum;
bool[] _winStyles = [false]; bool[] _winStyles = [false];
bool winStyle() bool winStyle()
@ -183,7 +175,10 @@ unittest
interface puma {} // [warn]: Interface name 'puma' does not match style guidelines. interface puma {} // [warn]: Interface name 'puma' does not match style guidelines.
struct dog {} // [warn]: Struct name 'dog' does not match style guidelines. struct dog {} // [warn]: Struct name 'dog' does not match style guidelines.
enum racoon { a } // [warn]: Enum name 'racoon' does not match style guidelines. enum racoon { a } // [warn]: Enum name 'racoon' does not match style guidelines.
enum bool Something = false; enum bool something = false;
enum bool someThing = false;
enum Cat { fritz, }
enum Cat = Cat.fritz;
}c, sac); }c, sac);
assertAnalyzerWarnings(q{ assertAnalyzerWarnings(q{