From 511cee29dc361cf103f3b369b4034297039a4760 Mon Sep 17 00:00:00 2001 From: Basile Burg Date: Sun, 6 Aug 2017 02:09:06 +0200 Subject: [PATCH] fix #452 - false pos for namz style for VariableDecl with the "enum" storage class --- src/analysis/style.d | 15 +++++---------- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/src/analysis/style.d b/src/analysis/style.d index d699c88..3e76180 100644 --- a/src/analysis/style.d +++ b/src/analysis/style.d @@ -70,18 +70,12 @@ final class StyleChecker : BaseAnalyzer override void visit(const VariableDeclaration vd) { - import std.algorithm.iteration : filter; - - varIsEnum = !vd.storageClasses.filter!(a => a.token == tok!"enum").empty; vd.accept(this); } override void visit(const Declarator dec) { - if (varIsEnum) - checkAggregateName("Variable", dec.name); - else - checkLowercaseName("Variable", dec.name); + checkLowercaseName("Variable", dec.name); } override void visit(const FunctionDeclaration dec) @@ -143,8 +137,6 @@ final class StyleChecker : BaseAnalyzer aggregateType ~ " name '" ~ name.text ~ "' does not match style guidelines."); } - bool varIsEnum; - bool[] _winStyles = [false]; bool winStyle() @@ -183,7 +175,10 @@ unittest interface puma {} // [warn]: Interface name 'puma' does not match style guidelines. struct dog {} // [warn]: Struct name 'dog' does not match style guidelines. enum racoon { a } // [warn]: Enum name 'racoon' does not match style guidelines. - enum bool Something = false; + enum bool something = false; + enum bool someThing = false; + enum Cat { fritz, } + enum Cat = Cat.fritz; }c, sac); assertAnalyzerWarnings(q{