Commit graph

108 commits

Author SHA1 Message Date
Martin Nowak
39652cbd70 Merge pull request #1757 from jpf91/fixCurl
[urgent] Fix possible stack corruption in std.net.curl
2013-12-15 13:51:36 -08:00
gittywithexcitement
672b98677a update onReceive documentation
Return value description was incomplete.
2013-12-12 00:46:59 -08:00
Johannes Pfau
6392e8af36 Fix possible stack corruption in std.net.curl
The HTTP and SMTP structs are used as value types. The delegate created
in onReceiveHeader stores a pointer to this HTTP as it needs to access
this.p so we potentially leak a reference to a stack variable here.

As the Impl struct is always allocated on the heap via RefCounted
storing a pointer to Impl is not an issue. So we move the delegate
generation out of HTTP and into impl to make sure it only stores a
pointer to Impl which will stay valid even if the original HTTP object
is moved.

Also reset some delegates in _basicHTTP and _basicFTP to avoid leaving
references to stack variables around.
2013-12-07 20:30:00 +01:00
Carlos Une
cab6c58379 Fix Issue 9737 - std.net.curl and SSL - documentation missing 2013-11-11 22:28:08 -02:00
SeeSchloss
be87817e03 Documentation precisions regarding HTTP/FTP charset encoding 2013-10-19 16:19:48 +02:00
Lionello Lunesu
b4074054ba Fix issue 10893: added missing or renamed DDoc parameters (found by fix to 10236) 2013-08-31 15:36:29 +08:00
Alex Rønne Petersen
931442d539 Merge pull request #1369 from AndrejMitrovic/IsemailFix
Deglobalize default threshold value, and fix initialization of threshold variable
2013-06-30 08:20:21 -07:00
Andrej Mitrovic
4da1639c98 Merge pull request #1337 from 9rnsr/fix_attrs
Potentially @safe & pure formatting
2013-06-27 18:53:22 -07:00
k-hara
03a32d6fa4 Fix issue 313 & 314 2013-06-25 08:38:30 +09:00
Andrej Mitrovic
8e4ef6aa8d Deglobalize default threshold value, and fix initialization of threshold variable. 2013-06-24 22:25:42 +02:00
k-hara
92bef24f2f fix Issue 10254 - Purity correctness is broken with constructor 2013-06-20 10:54:30 +09:00
Jacob Carlborg
c08f47e52c Use escape sequence for DELETE character.
This is just to make it a bit clearer what's going on.
2013-03-23 17:55:05 +01:00
Jacob Carlborg
f6e27e6f79 Enable a bunch of tests for std.net.isemail.
These tests were previously commented out because of a bug
the regular expression module. Now when we have a new regular
expression module we can enable these tests.

This also fixed a bug in the internally used "substr" function.
2013-03-22 15:44:58 +01:00
Sean Kelly
0d5cf70137 Changed default SSL peer and host verify to TRUE. Added verifyPeer and verifyHost @properties. 2013-01-22 14:30:49 -08:00
Sean Kelly
f2eb096913 updated HTTP client to work with hosts that have an unofficial SSL cert. This matches the behavior in the SMTP client. 2013-01-17 12:24:52 -08:00
Denis Shelomovskij
8ba35528ee Remvoe tab introduced in pull #1043
Just remove the tab.
2013-01-09 15:27:20 +04:00
Carlos Une
0263398c13 indent 2012-12-29 18:22:30 -02:00
Carlos Une
3ef5d2ad66 Set CA certificates of HTTP 2012-12-29 17:41:35 -02:00
Alex Rønne Petersen
1c22141596 Merge pull request #967 from 9rnsr/enforceProperty
For the more property enforcement
2012-11-22 22:29:20 -08:00
k-hara
01df2f60be Remove redundant parenthesis for getters, and use assignment syntax for setters 2012-11-23 15:07:17 +09:00
k-hara
2897ca8807 fix Issue 9062 - AddrExp should distinguish the existence of property resolution 2012-11-23 14:25:24 +09:00
Alex Rønne Petersen
5e9b90f9e2 Merge pull request #860 from CyberShadow/std-net-curl-onseek
std.net.curl: Implement seeking in basic HTTP requests
2012-10-19 09:13:17 -07:00
alexrp
b202180295 Remove all uses of sizediff_t in favor of ptrdiff_t. 2012-10-15 04:24:09 +02:00
Vladimir Panteleev
dc5b328d52 std.net.curl: Add unittest for seeking in basic HTTP requests 2012-10-15 03:08:12 +03:00
Vladimir Panteleev
6625029c1c std.net.curl: Implement seeking in basic HTTP requests
This enables reposting the data after a redirect, for example.
2012-10-11 02:03:10 +03:00
Andrei Alexandrescu
cbc0b9a9ca Merge pull request #761 from jmdavis/string
Removed deprecated functions in std.string
2012-10-06 21:50:28 -07:00
Torarin
25e4acd1b5 More tests for std.net.curl.byLine and std.net.curl.byChunk 2012-10-06 14:34:22 +02:00
torarin
2b234a264f Insert missing "HTTP." in front of Method.undefined in std.net.curl._getForRange. 2012-10-06 14:34:16 +02:00
jmdavis
27469366a7 Fix modules which incorrectly use std.string's public imports.
Now, they should be correctly importing for the functions publicly
imported by std.string so that if those public imports are ever removed,
they won't break.
2012-09-30 03:29:37 -07:00
Walter Bright
bf119860f4 fix Win64 varargs bug 2012-09-26 19:26:32 -07:00
Vladimir Panteleev
0a9fbcffb0 std.net.curl: Use std.file.tempDir() in unittests 2012-09-26 08:58:27 +03:00
Andrei Alexandrescu
416ac1f4e9 Merge pull request #801 from CyberShadow/std-net-curl-put-example
std.net.curl: Fix broken HTTP PUT example
2012-09-25 22:27:42 -07:00
Andrei Alexandrescu
87eb83d3b8 Merge pull request #800 from CyberShadow/std-net-curl-binary-post
std.net.curl: Do not assume POST data is null-terminated string
2012-09-25 22:27:11 -07:00
Vladimir Panteleev
57ec88f460 std.net.curl: Do not assume POST data is null-terminated string
This fixes uploading data not containing null characters, or
non-null-terminated data.
2012-09-18 03:58:06 +03:00
Vladimir Panteleev
39f7ea6ccc std.net.curl: Fix broken HTTP PUT example 2012-09-18 03:51:59 +03:00
Vladimir Panteleev
16f0b2ad56 std.net.curl: Fix unittests on Windows 2012-09-18 03:04:55 +03:00
Johannes Pfau
184cc8247d Fix dataTimeout in std.net.curl
* std.net.curl: Added operationTimeout.
* std.net.curl: dataTimeout fixed. (Used to set operation
  timeout instead of inactivity timeout)
2012-09-17 15:11:17 +02:00
SHOO
ede978cb39 Fix for issue 8558 2012-08-18 20:48:24 +09:00
Andrei Alexandrescu
be4bdc5dfa Fix documentation build 2012-04-13 22:05:29 -05:00
Jonas Drewsen
be9cbd854f Automatically add protocol if not present to improve protocol detection.
Set upload curl option on FTP file uploads
2012-04-07 22:05:22 +02:00
k-hara
844b1e16ad final @property 2012-03-20 01:55:31 +09:00
k-hara
80f0da80f8 More @property 2012-03-20 01:03:05 +09:00
Denis Shelomovskij
296de58334 cast(string) is neither necessary nor safe
*`curl_easy_strerror` isn't documented as returning immutable string
2012-02-20 17:05:12 +04:00
Jimmy Cao
8d02b47947 core.stdc.*string*.strlen 2012-02-18 12:49:52 -06:00
Jimmy Cao
1c50ab9659 avoid 1 allocation (per suggestion from Andrei) 2012-02-18 12:43:25 -06:00
Jimmy Cao
b801b26d41 Make exceptions more informative 2012-02-14 23:49:32 -06:00
dawg
a55c4bfaaa no, not the private _TypeTuple from core.time 2012-02-01 02:55:44 +01:00
dawg
2c32205d46 remove access to private function
- std.net.curl uses RefCountedAutoInitialize.yes
2012-01-30 22:44:16 +01:00
Jonas Drewsen
47b785d804 remove unneeded docs 2012-01-25 15:09:11 +01:00
Jonas Drewsen
3a893c3982 Remove docs for async ranges because the ranges are being hidden in functions when bug 2458 has been fixed 2012-01-21 10:27:07 +01:00