This is another attempt to re-use the code in `Payload.reserve` --
similar to https://github.com/dlang/phobos/pull/8143 (commit 0b7bf8dc):
"std.container.Array: Simplify implementation of length (by calling reserve).".
Additionally, `Array`'s variadic constructor is now safer:
If `emplace`-ing an element fails, successfully `emplace`-d elements are now destroyed.
Example:
```
auto a = Array!S (S(0), S(1), S(2), S(3));
// If emplace-ing a[2] (as a copy of S(2)) fails:
// - pre-existing behaviour: a[1] and a[0] were not destroyed (bad);
// - new behaviour: a[1] and a[0] are destroyed (good).
```
A corresponding `unittest` has been added (`S.s_nDestroyed == S.s_nConstructed`):
When such a failure (`Exception`) is caught, there should be no leaked objects.
Implementation:
Previously:
- the `Payload` `length` used to be increased only once,
after having successfully `emplace`-d all elements,
thus incorrectly tracking the number of `emplace`-d elements during the loop
(but correctly tracking it after the loop -- iff the entire loop succeeded).
Now:
- the `Payload` `length` is incremented multiple times,
at each step i.e. after having successfully `emplace`-d each element,
thus correctly tracking the number of `emplace`-d elements during the loop.
Note:
When the constructor fails, the corresponding destructor is not run.
But the destructors for successfully constructed sub-objects are run;
in this case, the destructor for the `_data` sub-object is run --
and it is this destructor which destroys the successfully emplaced elements
(iff they have been correctly tracked).
[DSSv3] Fix Issue #21100: Add data() function to std.container.array.Array
Signed-off-by: Max Haughton <maxhaton@users.noreply.github.com>
Merged-on-behalf-of: Max Haughton <maxhaton@users.noreply.github.com>
Since ae90bc7, we can simplify unittests by using Array!bool ctor instead of
manually do .insertBack(...). This improves example code readability.
Signed-off-by: Luís Ferreira <contact@lsferreira.net>
insertAfter should receive a valid element or a Range of values according to
type T of the corresponding instance Array!T.
Signed-off-by: Luís Ferreira <contact@lsferreira.net>
The emplace() stuff was moved to druntime; for some reason, it's still
in Phobos.
I've diffed the two versions, and they are still almost identical (incl.
unittests); the druntime version appears to have seen some improvements
(e.g., forwarding r/lvalueness of the arguments) in the meantime.
* RedBlackTree.empty(): Annotated const
RedBlackTree is a template, therefore all other qualifiers
for empty(), length(), and opBinaryRight!"in" will be inferred:
pure, nothrow, @safe, @nogc.
* RedBlackTree.front, .back: inout
This is a warning that showed up when running the testsuite in GDC with
the -Wextra flag. Said warning is by design and based on the assumption
that any function declared to take a const pointer or reference as an
argument reads the pointed-to-object.
In the case of GC.addRange(), the possibility is that a scan could
occur before the memory is initialized, and the GC sees false pointers
as a result of that.
LDC 1.15 and GDC with optimizations enabled recognize that mulu
with a second argument of 1 will never overflow and elide unnecessary
operations but DMD and LDC 1.14 do not.
