Commit graph

898 commits

Author SHA1 Message Date
The Dlang Bot
a7bd1a3184
Merge pull request #7502 from MoonlightSentinel/move-safe
Fix Issue 20869 - `move` is overly trusting of `opPostMove`
merged-on-behalf-of: Nicholas Wilson <thewilsonator@users.noreply.github.com>
2020-05-31 04:33:26 +02:00
MoonlightSentinel
082f8300d9
Fix Issue 20869 - move is overly trusting of opPostMove
Remove the manual check whether move is `@safe` and instead let the
compiler do the attribute interference by adding appropriate @trusted
blocks.

Note:
I could've extend the current checks `trustedMoveImpl` but that could
easily miss other corner cases.
2020-05-29 13:35:07 +02:00
Biotronic
fd59b6a92e Fix issue 19525 2020-05-29 01:18:40 +02:00
Hiroki Noda
4cdc906b3e [Trivial] Use std.meta instead of std.typetuple 2020-05-13 10:49:16 +09:00
Martin Nowak
a7d8def71b Merge remote-tracking branch 'upstream/stable' into merge_stable 2020-05-11 19:29:12 +02:00
Vladimir Panteleev
793a78c588
Fix Issue 20799 - schwartzSort does not pin transformation results with indirections, leading to memory corruption 2020-05-06 09:57:21 +00:00
The Dlang Bot
6db7dce61d
Merge pull request #7459 from MoonlightSentinel/chunk-ref
Fix Issue 20496 - chunkby should support ref predicate
merged-on-behalf-of: Nicholas Wilson <thewilsonator@users.noreply.github.com>
2020-04-26 04:28:48 +02:00
MoonlightSentinel
8fd3b6d3a5
Fix Issue 20496 - chunkby should support ref predicate
Provide an lvalue when checking the predicate
2020-04-26 03:20:42 +02:00
MoonlightSentinel
54dbc0668c
Fix Issue 20751 - SortedRange with ref predicate parameters fails
isTwoWayCompatible should accept functions with ref parameters.
2020-04-26 00:44:39 +02:00
Geod24
62c72ca6ff Follow up review on PR 7441
Steven identified a couple mistakes in the massive round of linkification.
Fixing them here.
2020-04-15 02:15:04 +09:00
The Dlang Bot
ffca395ed2
Merge pull request #7441 from Geod24/bugzilla-links
Change all bug ID to links
merged-on-behalf-of: Vladimir Panteleev <CyberShadow@users.noreply.github.com>
2020-04-14 17:42:07 +02:00
Geod24
f349a76c24 Correct issue number: 93532 -> 19532 2020-04-14 23:34:18 +09:00
Steven Schveighoffer
637ba8560e Fix issue 20732. Do not invoke any complex copy construction for
std.algorithm.mutation.swap for the temporary.
2020-04-13 11:33:54 -04:00
Geod24
04f3979317 Replace 'Issue XXX' with Bugzilla links
Make the links clickable, as was done in the DMD repository.
Also avoids any ambiguity w.r.t. where the issue is stored.
2020-04-13 16:28:09 +09:00
Geod24
1fb724744a Enable @safe on cartesianProduct's Result.popFront
The DMD PR has long been pulled but the comment hasn't been fixed.
2020-04-13 02:34:16 +09:00
Geod24
4c85510313 Improve comment about issue 5710 2020-04-12 22:48:16 +09:00
Atila Neves
85aede0639 Remove version(assert) from TimSort
If `-debug` is passed to the compiler, `version(assert)` is true.
TimSort has a `version(assert)` that checks some invariants, and uses
std.format.format for better error messages. Unfortunately, since it
is templated code, this results in Phobos template instantiations of
`format` in the user's code when `-debug` is used.

Given that default dub builds use `-debug`, this is a very common
problem.

Instead of removing the invariant checks, this changes it so they only
happen when testing Phobos itself.
2020-04-09 19:06:35 +02:00
Atila Neves
69ae443df4 Replace .staticArray with explicit declarations 2020-03-19 16:18:53 +01:00
Atila Neves
825b72dc88 Restore changes to among unittest that fails on Windows 2020-03-19 15:03:20 +01:00
Atila Neves
9a6f9543cf Address style violations 2020-03-18 18:02:01 +01:00
Atila Neves
bdacde79c3 Add @nogc to all relevant unittests in comparison.d 2020-03-18 18:02:01 +01:00
Iain Buclaw
c882086f85 std.algorithm.iteration: Fix typo.
Taken from patch for gdc bugzilla PR other/93756
2020-03-14 19:13:45 +01:00
Martin Kinkelin
5497b666e4 std.algorithm.sorting: Enable binary transform function for schwartzSort
Receiving the element's index in the original range as 2nd parameter.
2020-01-25 04:36:33 +01:00
Atila Neves
f049f0fd4b Make one std.algorithm.iteration.map unittest @nogc 2020-01-22 12:51:02 +01:00
Alexandru Militaru
bb62aaca3d Replaced version (unittest) with version (StdUnittest) to avoid unnecessary overhead when compiling with -unittest 2020-01-19 14:05:17 +02:00
Bernhard Seckinger
66a2ba02fd Fix Issue 15891 - Compiler error when std.algorithm.cache after 2
layers of std.algorithm.map
2020-01-08 16:05:25 +01:00
Marco de Wild
d93e7be91d
Improved error message when calling sum without a default value
If sum() is called, it tries to find a default value by constructing it with 0 (e.g. float(0)). This works for numbers, but produces obscure errors if the value cannot be constructed this way (e.g. issue #19525). The error message now states that the problem lies in the default value and suggests to supply one instead.
2019-12-30 16:11:55 +01:00
Bernhard Seckinger
509e657872 Fix Issue 11013 - ignoring variable inside the predicate of findSplitBefore 2019-11-14 17:32:08 +01:00
Bernhard Seckinger
97abb91952 Fix Issue 10902 - some phobos unittests take an excessive amount of time 2019-11-12 20:21:03 +01:00
Bernhard Seckinger
14e5d1bce2 More min and max are not NaN aware. 2019-10-22 19:56:28 +02:00
Bernhard Seckinger
0320d88c3a Fix Issue 10448 - min and max are not NaN aware 2019-10-21 11:40:09 +02:00
Iain Buclaw
bb7bd70fbf Silence warning: struct Rebindable has method toHash, however it cannot be called with const(Rebindable!(const(C))) this. 2019-10-07 23:29:47 +02:00
Berni
58c3a75738 Fix Issue 15230 - Inconsistent std.range.SortedRange predicate checks 2019-09-29 19:39:05 +02:00
JinShil
0de2d66760 Replace hash_t and sizediff_t with size_t and ptrdiff_t 2019-08-31 04:39:57 +09:00
Martin Kinkelin
7653e97a32 Rewrite dubious refRange() shortcuts in unittests
As preparation for dlang/dmd#10124, which makes elements of array
literals rvalues.
2019-08-15 18:54:08 +02:00
Martin Nowak
d2e931f149 Merge remote-tracking branch 'upstream/stable' into merge_stable 2019-08-05 08:51:49 +02:00
The Dlang Bot
e123a4d1a8
Merge pull request #7102 from dgileadi/enable-markdown
Turn on -preview=markdown
merged-on-behalf-of: Nicholas Wilson <thewilsonator@users.noreply.github.com>
2019-07-24 02:48:50 +02:00
Brian Kessler
8a78157f04 std.algorithm.sorting: fix typo in pivotPartition 2019-07-21 23:22:34 -06:00
The Dlang Bot
1a66781127
Merge pull request #7006 from marcioapm/fix_19838
Fix Issue 19838 - RefCounted fails to instantiate due to pureness of …
merged-on-behalf-of: Nicholas Wilson <thewilsonator@users.noreply.github.com>
2019-07-10 13:11:38 +02:00
David Gileadi
775bcdee51 Turn on -preview=markdown 2019-07-04 10:28:30 -07:00
Les De Ridder
4be9b5f59f Implement Phobos side of DIP1014 2019-06-30 22:51:05 +02:00
The Dlang Bot
9fb63a5592
Merge pull request #7089 from burner/std.algorithm.searching_assert_messages
Adds asserts messages
merged-on-behalf-of: Nicholas Wilson <thewilsonator@users.noreply.github.com>
2019-06-26 15:05:07 +02:00
Robert Schadek
dbf9d93d95 Adds assert messages
review
2019-06-26 08:37:24 +01:00
The Dlang Bot
c256ecf65b
Merge pull request #7090 from burner/std.algorithm.setops_assert_messages
Addes assert messages
merged-on-behalf-of: Nicholas Wilson <thewilsonator@users.noreply.github.com>
2019-06-25 16:33:37 +02:00
Robert Schadek
bb767d5865 Addes assert messages 2019-06-25 12:09:33 +01:00
Robert Schadek
d9cf38b3a0
added a lost space 2019-06-25 11:50:35 +01:00
Robert Schadek
31d5b848b0 Adds asserts messages 2019-06-25 11:25:33 +01:00
The Dlang Bot
019df49d71
Merge pull request #7088 from burner/std.algorithm.iteration_assert_messages
Adds assert messages
merged-on-behalf-of: Nicholas Wilson <thewilsonator@users.noreply.github.com>
2019-06-25 12:10:05 +02:00
Robert Schadek
35d32abf3a Adds assert messages 2019-06-25 09:39:29 +01:00
Robert Schadek
ef71418e73 Adds assert messages 2019-06-25 09:16:27 +01:00