From d2be19720897026dbd5e9f7812ebd2c292527eeb Mon Sep 17 00:00:00 2001
From: Nathan Sashihara <21227491+n8sh@users.noreply.github.com>
Date: Fri, 17 May 2019 19:55:02 -0400
Subject: [PATCH] Remove unnecessary check-and-initialize in
 std.alorithm.internal.rndstuff

The check-and-initialize pattern dates back to when `rnd` was seeded
with `unpredictableSeed`. With a fixed seed that's unnecessary.
---
 std/algorithm/internal.d | 20 ++++----------------
 1 file changed, 4 insertions(+), 16 deletions(-)

diff --git a/std/algorithm/internal.d b/std/algorithm/internal.d
index 666584f82..71d72cff1 100644
--- a/std/algorithm/internal.d
+++ b/std/algorithm/internal.d
@@ -21,15 +21,9 @@ version (unittest)
 
     package string[] rndstuff(T : string)()
     {
-        import std.random : Random = Xorshift, uniform;
+        import std.random : Xorshift, uniform;
 
-        static Random rnd;
-        static bool first = true;
-        if (first)
-        {
-            rnd.seed(234_567_891);
-            first = false;
-        }
+        static rnd = Xorshift(234_567_891);
         string[] result =
             new string[uniform(minArraySize, maxArraySize, rnd)];
         string alpha = "abcdefghijABCDEFGHIJ";
@@ -46,15 +40,9 @@ version (unittest)
 
     package int[] rndstuff(T : int)()
     {
-        import std.random : Random = Xorshift, uniform;
+        import std.random : Xorshift, uniform;
 
-        static Random rnd;
-        static bool first = true;
-        if (first)
-        {
-            rnd = Random(345_678_912);
-            first = false;
-        }
+        static rnd = Xorshift(345_678_912);
         int[] result = new int[uniform(minArraySize, maxArraySize, rnd)];
         foreach (ref i; result)
         {