mirrors/phobos
1
0
Fork 0
mirror of https://github.com/dlang/phobos.git synced 2025-04-28 14:10:30 +03:00
Code Issues Projects Releases Packages Wiki Activity Actions

std.parallelism: replace explicit code with Throwable.chainTogether()

Browse source
This commit is contained in:
Walter Bright 2017-12-16 19:58:30 -08:00 • committed by Sebastian Wilzbach
parent dfc5fae8f3
commit b8291f2d5d
1 changed files with 10 additions and 36 deletions
Download patch file Download diff file Expand all files Collapse all files

46
std/parallelism.d
View file

@ -2780,7 +2780,7 @@ public:
// done or in progress. Force all of them. // done or in progress. Force all of them.
E result = seed; E result = seed;
Throwable firstException, lastException; Throwable firstException;
foreach (ref task; tasks) foreach (ref task; tasks)
{ {
@ -2790,7 +2790,10 @@ public:
} }
catch (Throwable e) catch (Throwable e)
{ {
addToChain(e, firstException, lastException); /* Chain e to front because order doesn't matter and because
* e is not likely to be a chain itself (so fewer traversals)
*/
firstException = Throwable.chainTogether(e, firstException);
continue; continue;
} }
@ -3512,7 +3515,7 @@ private void submitAndExecute(
} }
} }
Throwable firstException, lastException; Throwable firstException;
foreach (i, ref task; tasks) foreach (i, ref task; tasks)
{ {
@ -3522,7 +3525,10 @@ private void submitAndExecute(
} }
catch (Throwable e) catch (Throwable e)
{ {
addToChain(e, firstException, lastException); /* Chain e to front because order doesn't matter and because
* e is not likely to be a chain itself (so fewer traversals)
*/
firstException = Throwable.chainTogether(e, firstException);
continue; continue;
} }
} }
@ -3822,38 +3828,6 @@ enum string parallelApplyMixinInputRange = q{
return 0; return 0;
}; };
// Calls e.next until the end of the chain is found.
private Throwable findLastException(Throwable e) pure nothrow
{
if (e is null) return null;
while (e.next)
{
e = e.next;
}
return e;
}
// Adds e to the exception chain.
private void addToChain(
Throwable e,
ref Throwable firstException,
ref Throwable lastException
) pure nothrow
{
if (firstException)
{
assert(lastException); // nocoverage
lastException.next = e; // nocoverage
lastException = findLastException(e); // nocoverage
}
else
{
firstException = e;
lastException = findLastException(e);
}
}
private struct ParallelForeach(R) private struct ParallelForeach(R)
{ {