mirrors/phobos
1
0
Fork 0
mirror of https://github.com/dlang/phobos.git synced 2025-04-28 06:00:35 +03:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fix Issue 20242 - BitArray constructor should not modify input data

Browse source
This commit is contained in:
Vladimir Panteleev 2019-09-25 07:57:03 +00:00
parent 289149a2f1
commit b808e722b1
No known key found for this signature in database
GPG key ID: 5004F0FAD051576D
1 changed files with 4 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

14
std/bitmanip.d
View file

@ -1018,8 +1018,6 @@ public:
This constructor is the inverse of $(LREF opCast). This constructor is the inverse of $(LREF opCast).
$(RED Warning: All unmapped bits in the final word will be set to 0.)
Params: Params:
v = Source array. `v.length` must be a multple of `size_t.sizeof`. v = Source array. `v.length` must be a multple of `size_t.sizeof`.
numbits = Number of bits to be mapped from the source array, i.e. numbits = Number of bits to be mapped from the source array, i.e.
@ -1037,11 +1035,6 @@ public:
{ {
_ptr = cast(size_t*) v.ptr; _ptr = cast(size_t*) v.ptr;
_len = numbits; _len = numbits;
if (endBits)
{
// Need to mask away extraneous bits from v.
_ptr[dim - 1] &= endMask;
}
} }
/// ///
@ -1080,7 +1073,8 @@ public:
@system unittest @system unittest
{ {
// Example from the doc for this constructor. // Example from the doc for this constructor.
size_t[] source = [1, 0b101, 3, 3424234, 724398, 230947, 389492]; static immutable size_t[] sourceData = [1, 0b101, 3, 3424234, 724398, 230947, 389492];
size_t[] source = sourceData.dup;
enum sbits = size_t.sizeof * 8; enum sbits = size_t.sizeof * 8;
auto ba = BitArray(source, source.length * sbits); auto ba = BitArray(source, source.length * sbits);
foreach (n; 0 .. source.length * sbits) foreach (n; 0 .. source.length * sbits)
@ -1094,8 +1088,8 @@ public:
auto bc = BitArray(source, sbits + 1); auto bc = BitArray(source, sbits + 1);
assert(bc.bitsSet.equal([0, sbits])); assert(bc.bitsSet.equal([0, sbits]));
// The unmapped bits from the final word have been cleared. // Source array has not been modified.
assert(source[1] == 1); assert(source == sourceData);
} }
// Deliberately undocumented: raw initialization of bit array. // Deliberately undocumented: raw initialization of bit array.