mirrors/phobos
1
0
Fork 0
mirror of https://github.com/dlang/phobos.git synced 2025-05-11 23:05:34 +03:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

fix test failure for updated Windows TZs

Browse source 
- change to list all missing WinTZ translations when running std/datetime
  unittests w/ -version=UpdateWindowsTZTranslations so they can be
  updated manually
This commit is contained in:
Martin Nowak 2016-07-09 12:50:02 +02:00
parent 02d1aedf6d
commit aa88e7bc8e
1 changed files with 21 additions and 15 deletions
Download patch file Download diff file Expand all files Collapse all files

36
std/datetime.d
View file

@ -122,6 +122,12 @@ version(Windows)
import core.sys.windows.windows; import core.sys.windows.windows;
import core.sys.windows.winsock2; import core.sys.windows.winsock2;
import std.windows.registry; import std.windows.registry;
// Uncomment and run unittests to print missing Windows TZ translations.
// Please subscribe to Microsoft Daylight Saving Time & Time Zone Blog
// (https://blogs.technet.microsoft.com/dst2007/) if you feel responsible
// for updating the translations.
// version = UpdateWindowsTZTranslations;
} }
else version(Posix) else version(Posix)
{ {
@ -27270,7 +27276,6 @@ public:
{ {
import std.array : appender; import std.array : appender;
import std.algorithm : startsWith, sort; import std.algorithm : startsWith, sort;
import std.format : format;
auto windowsNames = WindowsTimeZone.getInstalledTZNames(); auto windowsNames = WindowsTimeZone.getInstalledTZNames();
auto retval = appender!(string[])(); auto retval = appender!(string[])();
@ -27278,13 +27283,6 @@ public:
foreach(winName; windowsNames) foreach(winName; windowsNames)
{ {
auto tzName = windowsTZNameToTZDatabaseName(winName); auto tzName = windowsTZNameToTZDatabaseName(winName);
version(unittest)
{
import std.string;
assert(tzName !is null, format("TZName which is missing: %s", winName));
}
if(tzName !is null && tzName.startsWith(subName)) if(tzName !is null && tzName.startsWith(subName))
retval.put(tzName); retval.put(tzName);
} }
@ -30660,11 +30658,15 @@ string tzDatabaseNameToWindowsTZName(string tzName) @safe pure nothrow @nogc
} }
} }
version(Windows) unittest version(Windows) version(UpdateWindowsTZTranslations) unittest
{ {
import std.format : format; import std.stdio : stderr;
foreach(tzName; TimeZone.getInstalledTZNames()) foreach(tzName; TimeZone.getInstalledTZNames())
assert(tzDatabaseNameToWindowsTZName(tzName) !is null, format("TZName which failed: %s", tzName)); {
if (tzDatabaseNameToWindowsTZName(tzName) is null)
stderr.writeln("Missing TZName to Windows translation: ", tzName);
}
} }
@ -30818,11 +30820,15 @@ string windowsTZNameToTZDatabaseName(string tzName) @safe pure nothrow @nogc
} }
} }
version(Windows) unittest version(Windows) version(UpdateWindowsTZTranslations) unittest
{ {
import std.format : format; import std.stdio : stderr;
foreach(tzName; WindowsTimeZone.getInstalledTZNames())
assert(windowsTZNameToTZDatabaseName(tzName) !is null, format("TZName which failed: %s", tzName)); foreach(winName; WindowsTimeZone.getInstalledTZNames())
{
if (windowsTZNameToTZDatabaseName(winName) is null)
stderr.writeln("Missing Windows to TZName translation: ", winName);
}
} }