mirrors/phobos
1
0
Fork 0
mirror of https://github.com/dlang/phobos.git synced 2025-05-01 07:30:33 +03:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fix issue 22785: joiner should Unqual child ranges. (#8737)

Browse source 
* Fix issue 22785: `joiner` should `Unqual` child ranges.
This allows use with `immutable T[][]` and similar.

---------

Co-authored-by: Petar Kirov <petar.p.kirov@gmail.com>
This commit is contained in:
FeepingCreature 2023-04-20 00:59:19 +02:00 • committed by GitHub
parent c26d25eecd
commit 656ae7905e
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 25 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

28
std/algorithm/iteration.d
View file

@ -3632,18 +3632,18 @@ auto joiner(RoR, Separator)(RoR r, Separator sep)
/// Ditto /// Ditto
auto joiner(RoR)(RoR r) auto joiner(RoR)(RoR r)
if (isInputRange!RoR && isInputRange!(ElementType!RoR)) if (isInputRange!RoR && isInputRange!(Unqual!(ElementType!RoR)))
{ {
static struct Result static struct Result
{ {
private: private:
RoR _items; RoR _items;
ElementType!RoR _current; Unqual!(ElementType!RoR) _current;
enum isBidirectional = isForwardRange!RoR && isForwardRange!(ElementType!RoR) && enum isBidirectional = isForwardRange!RoR && isForwardRange!(ElementType!RoR) &&
isBidirectionalRange!RoR && isBidirectionalRange!(ElementType!RoR); isBidirectionalRange!RoR && isBidirectionalRange!(ElementType!RoR);
static if (isBidirectional) static if (isBidirectional)
{ {
ElementType!RoR _currentBack; Unqual!(ElementType!RoR) _currentBack;
bool reachedFinalElement; bool reachedFinalElement;
} }
@ -4293,6 +4293,28 @@ if (isInputRange!RoR && isInputRange!(ElementType!RoR))
assert([only(S(null))].joiner.front == S(null)); assert([only(S(null))].joiner.front == S(null));
} }
// https://issues.dlang.org/show_bug.cgi?id=22785
@safe unittest
{
import std.algorithm.iteration : joiner, map;
import std.array : array;
static immutable struct S
{
int value;
}
static immutable struct T
{
S[] arr;
}
auto range = [T([S(3)]), T([S(4), S(5)])];
assert(range.map!"a.arr".joiner.array == [S(3), S(4), S(5)]);
}
/++ /++
Implements the homonym function (also known as `accumulate`, $(D Implements the homonym function (also known as `accumulate`, $(D
compress), `inject`, or `foldl`) present in various programming compress), `inject`, or `foldl`) present in various programming