mirrors/phobos
1
0
Fork 0
mirror of https://github.com/dlang/phobos.git synced 2025-04-28 06:00:35 +03:00
Code Issues Projects Releases Packages Wiki Activity Actions

Remove alias this from classes in phobos

Browse source
This commit is contained in:
RazvanN7 2023-01-26 14:35:08 +02:00
parent 6eaa69f12d
commit 61658d2372
4 changed files with 2 additions and 191 deletions
Download patch file Download diff file Expand all files Collapse all files

16
std/array.d
View file

@ -2294,22 +2294,6 @@ if (isInputRange!RoR &&
}
}
// https://issues.dlang.org/show_bug.cgi?id=10895
@safe unittest
{
static class A
{
string name;
alias name this;
this(string name) { this.name = name; }
}
auto a = [new A(`foo`)];
assert(a[0].length == 3);
auto temp = join(a, " ");
assert(a[0].length == 3);
assert(temp.length == 3);
}
// https://issues.dlang.org/show_bug.cgi?id=14230
@safe unittest
{

2
std/exception.d
View file

@ -1536,7 +1536,7 @@ version (StdUnittest)
@safe unittest //more alias this opCast
{
void* p;
class A
struct A
{
void* opCast(T)() if (is(T == void*))
{

173
std/format/internal/write.d
View file

@ -50,27 +50,6 @@ if (is(BooleanTypeOf!T) && !is(T == enum) && !hasToString!(T, Char))
@safe unittest
{
class C1
{
bool val;
alias val this;
this(bool v){ val = v; }
}
class C2 {
bool val;
alias val this;
this(bool v){ val = v; }
override string toString() const { return "C"; }
}
() @trusted {
formatTest(new C1(false), "false");
formatTest(new C1(true), "true");
formatTest(new C2(false), "C");
formatTest(new C2(true), "C");
} ();
struct S1
{
bool val;
@ -411,26 +390,6 @@ private uint baseOfSpec(in char spec) @safe pure
@safe unittest
{
class C1
{
long val;
alias val this;
this(long v){ val = v; }
}
class C2
{
long val;
alias val this;
this(long v){ val = v; }
override string toString() const { return "C"; }
}
() @trusted {
formatTest(new C1(10), "10");
formatTest(new C2(10), "C");
} ();
struct S1
{
long val;
@ -709,26 +668,6 @@ if (is(FloatingPointTypeOf!T) && !is(T == enum) && !hasToString!(T, Char))
{
formatTest(2.25, "2.25");
class C1
{
double val;
alias val this;
this(double v){ val = v; }
}
class C2
{
double val;
alias val this;
this(double v){ val = v; }
override string toString() const { return "C"; }
}
() @trusted {
formatTest(new C1(2.25), "2.25");
formatTest(new C2(2.25), "C");
} ();
struct S1
{
double val;
@ -1078,26 +1017,6 @@ if (is(CharTypeOf!T) && !is(T == enum) && !hasToString!(T, Char))
@safe unittest
{
class C1
{
char val;
alias val this;
this(char v){ val = v; }
}
class C2
{
char val;
alias val this;
this(char v){ val = v; }
override string toString() const { return "C"; }
}
() @trusted {
formatTest(new C1('c'), "c");
formatTest(new C2('c'), "C");
} ();
struct S1
{
char val;
@ -1165,26 +1084,6 @@ if (is(StringTypeOf!T) && !is(StaticArrayTypeOf!T) && !is(T == enum) && !hasToSt
@safe unittest
{
// Test for bug 5371 for classes
class C1
{
const string var;
alias var this;
this(string s){ var = s; }
}
class C2
{
string var;
alias var this;
this(string s){ var = s; }
}
() @trusted {
formatTest(new C1("c1"), "c1");
formatTest(new C2("c2"), "c2");
} ();
// Test for bug 5371 for structs
struct S1
{
@ -1204,16 +1103,6 @@ if (is(StringTypeOf!T) && !is(StaticArrayTypeOf!T) && !is(T == enum) && !hasToSt
@safe unittest
{
class C3
{
string val;
alias val this;
this(string s){ val = s; }
override string toString() const { return "C"; }
}
() @trusted { formatTest(new C3("c3"), "C"); } ();
struct S3
{
string val; alias val this;
@ -1436,36 +1325,6 @@ if (is(DynamicArrayTypeOf!T) && !is(StringTypeOf!T) && !is(T == enum) && !hasToS
formatTest(S!0b101([0, 1, 2]), "S"); // Test for bug 7628
formatTest(S!0b110([0, 1, 2]), "S");
formatTest(S!0b111([0, 1, 2]), "S");
class C(uint flags)
{
int[] arr;
static if (flags & 1)
alias arr this;
this(int[] a) { arr = a; }
static if (flags & 2)
{
@property bool empty() const { return arr.length == 0; }
@property int front() const { return arr[0] * 2; }
void popFront() { arr = arr[1 .. $]; }
}
static if (flags & 4)
override string toString() const { return "C"; }
}
() @trusted {
formatTest(new C!0b000([0, 1, 2]), (new C!0b000([])).toString());
formatTest(new C!0b001([0, 1, 2]), "[0, 1, 2]"); // Test for bug 7628
formatTest(new C!0b010([0, 1, 2]), "[0, 2, 4]");
formatTest(new C!0b011([0, 1, 2]), "[0, 2, 4]");
formatTest(new C!0b100([0, 1, 2]), "C");
formatTest(new C!0b101([0, 1, 2]), "C"); // Test for bug 7628
formatTest(new C!0b110([0, 1, 2]), "C");
formatTest(new C!0b111([0, 1, 2]), "C");
} ();
}
@safe unittest
@ -1901,26 +1760,6 @@ if (is(AssocArrayTypeOf!T) && !is(T == enum) && !hasToString!(T, Char))
@safe unittest
{
class C1
{
int[char] val;
alias val this;
this(int[char] v){ val = v; }
}
class C2
{
int[char] val;
alias val this;
this(int[char] v){ val = v; }
override string toString() const { return "C"; }
}
() @trusted {
formatTest(new C1(['c':1, 'd':2]), [`['c':1, 'd':2]`, `['d':2, 'c':1]`]);
formatTest(new C2(['c':1, 'd':2]), "C");
} ();
struct S1
{
int[char] val;
@ -3167,18 +3006,6 @@ if (isPointer!T && !is(T == enum) && !hasToString!(T, Char))
formatTest(q, "FFEECCAA");
}
// https://issues.dlang.org/show_bug.cgi?id=8186
@system unittest
{
class B
{
int* a;
this() { a = new int; }
alias a this;
}
formatTest(B.init, "null");
}
// https://issues.dlang.org/show_bug.cgi?id=9336
@system pure unittest
{

2
std/traits.d
View file

@ -6066,7 +6066,7 @@ template StringTypeOf(T)
static assert(is(Q!T[] == StringTypeOf!( SubTypeOf!(Q!T[]) )));
alias Str = Q!T[];
class C(S) { S val; alias val this; }
struct C(S) { S val; alias val this; }
static assert(is(StringTypeOf!(C!Str) == Str));
}}
}