mirrors/phobos
1
0
Fork 0
mirror of https://github.com/dlang/phobos.git synced 2025-05-01 15:40:36 +03:00
Code Issues Projects Releases Packages Wiki Activity Actions

Merge pull request #5157 from wilzbach/dscanner-builtin-conflict

Browse source 
Dscanner: enable check for conflicts with builtin properties
This commit is contained in:
Jack Stouffer 2017-02-20 13:50:16 -05:00 • committed by GitHub
commit 19e240f136
3 changed files with 9 additions and 15 deletions
Download patch file Download diff file Expand all files Collapse all files

2
.dscanner.ini
View file

@ -33,7 +33,7 @@ opequals_tohash_check="disabled"
; Checks for subtraction from .length properties ; Checks for subtraction from .length properties
length_subtraction_check="disabled" length_subtraction_check="disabled"
; Checks for methods or properties whose names conflict with built-in properties ; Checks for methods or properties whose names conflict with built-in properties
builtin_property_names_check="disabled"; FIXME builtin_property_names_check="enabled"; FIXME
; Checks for confusing code in inline asm statements ; Checks for confusing code in inline asm statements
asm_style_check="disabled"; FIXME asm_style_check="disabled"; FIXME
; Checks for confusing logical operator precedence ; Checks for confusing logical operator precedence

6
std/algorithm/mutation.d
View file

@ -2657,12 +2657,6 @@ pure @safe nothrow unittest
{ {
T payload; T payload;
// needed for ElementType
auto init()
{
return payload.init;
}
ElementType!T moveAt(size_t i) ElementType!T moveAt(size_t i)
{ {
return payload.moveAt(i); return payload.moveAt(i);

16
std/internal/test/dummyrange.d
View file

@ -325,7 +325,7 @@ if (is(T == uint))
return iota(cast(uint)low, cast(uint)high); return iota(cast(uint)low, cast(uint)high);
} }
static void init(ref uint[] arr) static void initialize(ref uint[] arr)
{ {
import std.array : array; import std.array : array;
arr = iota().array; arr = iota().array;
@ -348,7 +348,7 @@ if (is(T == double))
return iota(cast(double)low, cast(double)high, 1.0); return iota(cast(double)low, cast(double)high, 1.0);
} }
static void init(ref double[] arr) static void initialize(ref double[] arr)
{ {
import std.array : array; import std.array : array;
arr = iota().array; arr = iota().array;
@ -395,7 +395,7 @@ if (is(T == TestFoo))
return iota(cast(int)low, cast(int)high).map!(a => TestFoo(a)); return iota(cast(int)low, cast(int)high).map!(a => TestFoo(a));
} }
static void init(ref TestFoo[] arr) static void initialize(ref TestFoo[] arr)
{ {
import std.array : array; import std.array : array;
arr = iota().array; arr = iota().array;
@ -426,7 +426,7 @@ unittest
static void testInputRange(T,Cmp)() static void testInputRange(T,Cmp)()
{ {
T it; T it;
Cmp.init(it.arr); Cmp.initialize(it.arr);
for (size_t numRuns = 0; numRuns < 2; ++numRuns) for (size_t numRuns = 0; numRuns < 2; ++numRuns)
{ {
if (numRuns == 1) if (numRuns == 1)
@ -436,7 +436,7 @@ unittest
it.reinit(); it.reinit();
} }
Cmp.init(it.arr); Cmp.initialize(it.arr);
} }
assert(equal!(Cmp.cmp)(it, Cmp.iota(1, 11))); assert(equal!(Cmp.cmp)(it, Cmp.iota(1, 11)));
@ -478,7 +478,7 @@ unittest
static void testForwardRange(T,Cmp)() static void testForwardRange(T,Cmp)()
{ {
T it; T it;
Cmp.init(it.arr); Cmp.initialize(it.arr);
auto s = it.save(); auto s = it.save();
s.popFront(); s.popFront();
assert(!Cmp.cmp(s.front, it.front)); assert(!Cmp.cmp(s.front, it.front));
@ -487,7 +487,7 @@ unittest
static void testBidirectionalRange(T,Cmp)() static void testBidirectionalRange(T,Cmp)()
{ {
T it; T it;
Cmp.init(it.arr); Cmp.initialize(it.arr);
assert(equal!(Cmp.cmp)(it.retro, Cmp.iota().retro)); assert(equal!(Cmp.cmp)(it.retro, Cmp.iota().retro));
auto s = it.back; auto s = it.back;
@ -500,7 +500,7 @@ unittest
static void testRandomAccessRange(T,Cmp)() static void testRandomAccessRange(T,Cmp)()
{ {
T it; T it;
Cmp.init(it.arr); Cmp.initialize(it.arr);
size_t idx = 0; size_t idx = 0;
foreach (jt; it) foreach (jt; it)
{ {