mirrors/ldc
1
0
Fork 0
mirror of https://github.com/ldc-developers/ldc.git synced 2025-04-29 06:30:39 +03:00
Code Issues Projects Releases Packages Wiki Activity Actions

Optimize ABIRewrite system for lvalues

Browse source 
Allow ABIRewrites to return the D parameter's LL value directly.
Most rewrites store to memory anyway, so let the D parameter point
directly to that memory instead of a dedicated alloca bitcopy.
This commit is contained in:
Martin 2016-05-28 16:08:44 +02:00
parent a6a6786d8d
commit fc6c340661
9 changed files with 84 additions and 141 deletions
Download patch file Download diff file Expand all files Collapse all files

28
gen/llvmhelpers.cpp
View file

@ -227,14 +227,14 @@ LLValue *DtoAllocaDump(LLValue *val, Type *asType, const char *name) {
LLValue *DtoAllocaDump(LLValue *val, LLType *asType, int alignment,
const char *name) {
LLType *valType = i1ToI8(voidToI8(val->getType()));
asType = i1ToI8(voidToI8(asType));
LLType *memType = i1ToI8(voidToI8(val->getType()));
LLType *asMemType = i1ToI8(voidToI8(asType));
LLType *allocaType =
(getTypeStoreSize(valType) <= getTypeAllocSize(asType) ? asType
: valType);
(getTypeStoreSize(memType) <= getTypeAllocSize(asMemType) ? asMemType
: memType);
LLValue *mem = DtoRawAlloca(allocaType, alignment, name);
DtoStoreZextI8(val, DtoBitCast(mem, valType->getPointerTo()));
return DtoBitCast(mem, asType->getPointerTo());
DtoStoreZextI8(val, DtoBitCast(mem, memType->getPointerTo()));
return DtoBitCast(mem, asMemType->getPointerTo());
}
/******************************************************************************
@ -1602,18 +1602,10 @@ DValue *DtoSymbolAddress(Loc &loc, Type *type, Declaration *decl) {
assert(type->ty == Tdelegate);
return new DVarValue(type, getIrValue(vd));
}
if (vd->isRef() || vd->isOut() || DtoIsInMemoryOnly(vd->type) ||
llvm::isa<llvm::AllocaInst>(getIrValue(vd))) {
assert(!isSpecialRefVar(vd) && "Code not expected to handle special "
"ref vars, although it can easily be "
"made to.");
return new DVarValue(type, getIrValue(vd));
}
if (llvm::isa<llvm::Argument>(getIrValue(vd))) {
return new DImValue(type, getIrValue(vd));
}
llvm_unreachable("Unexpected parameter value.");
assert(!isSpecialRefVar(vd) && "Code not expected to handle special "
"ref vars, although it can easily be "
"made to.");
return new DVarValue(type, getIrValue(vd));
} else {
Logger::println("a normal variable");