mirrors/ldc
1
0
Fork 0
mirror of https://github.com/ldc-developers/ldc.git synced 2025-05-04 00:55:49 +03:00
Code Issues Projects Releases Packages Wiki Activity Actions

Refactor away LDC-specific FuncDeclaration::intrinsicName (#4595)

Browse source 
Using `mangleOverride` directly instead. Also get rid of superfluous
string copies. And for LLVMatomic_rmw, don't store the operation
string in the instantiated FuncDeclarations anymore, but fetch it
from the parent TemplateDeclaration.
This commit is contained in:
Martin Kinkelin 2024-03-21 16:50:06 +01:00 • committed by GitHub
parent 23b8411191
commit ef72dedd7c
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
7 changed files with 20 additions and 23 deletions
Download patch file Download diff file Expand all files Collapse all files

12
gen/llvmhelpers.cpp
View file

@ -1242,6 +1242,8 @@ static char *DtoOverloadedIntrinsicName(TemplateInstance *ti,
IF_LOG Logger::println("DtoOverloadedIntrinsicName");
LOG_SCOPE;
assert(td->intrinsicName);
IF_LOG {
Logger::println("template instance: %s", ti->toChars());
Logger::println("template declaration: %s", td->toChars());
@ -1304,7 +1306,7 @@ static char *DtoOverloadedIntrinsicName(TemplateInstance *ti,
IF_LOG Logger::println("final intrinsic name: %s", name.c_str());
return strdup(name.c_str());
return mem.xstrdup(name.c_str());
}
/// For D frontend
@ -1312,11 +1314,9 @@ static char *DtoOverloadedIntrinsicName(TemplateInstance *ti,
void DtoSetFuncDeclIntrinsicName(TemplateInstance *ti, TemplateDeclaration *td,
FuncDeclaration *fd) {
if (fd->llvmInternal == LLVMintrinsic) {
fd->intrinsicName = DtoOverloadedIntrinsicName(ti, td);
const auto cstr = fd->intrinsicName;
fd->mangleOverride = {cstr ? strlen(cstr) : 0, cstr};
} else {
fd->intrinsicName = td->intrinsicName ? strdup(td->intrinsicName) : nullptr;
const auto cstr = DtoOverloadedIntrinsicName(ti, td);
assert(cstr);
fd->mangleOverride = {strlen(cstr), cstr};
}
}