mirrors/ldc
1
0
Fork 0
mirror of https://github.com/ldc-developers/ldc.git synced 2025-05-03 08:30:47 +03:00
Code Issues Projects Releases Packages Wiki Activity Actions

AVR: Add predefined version AVR and emit TLS globals as regular ones (#3420)

Browse source 
The AVR target on LLVM and AVR-GCC does not have support for TLS, so
it is necessary to emit global variables as NotThreadLocal.
This commit is contained in:
Ernesto Castellotti 2020-05-08 22:47:10 +02:00 • committed by GitHub
parent 920fe2cff7
commit c40bbbc320
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 21 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

4
driver/main.cpp
View file

@ -651,6 +651,10 @@ void registerPredefinedTargetVersions() {
VersionCondition::addPredefinedGlobalIdent("AArch64"); VersionCondition::addPredefinedGlobalIdent("AArch64");
registerPredefinedFloatABI("ARM_SoftFloat", "ARM_HardFloat", "ARM_SoftFP"); registerPredefinedFloatABI("ARM_SoftFloat", "ARM_HardFloat", "ARM_SoftFP");
break; break;
case llvm::Triple::avr:
VersionCondition::addPredefinedGlobalIdent("AVR");
VersionCondition::addPredefinedGlobalIdent("D_SoftFloat");
break;
case llvm::Triple::mips: case llvm::Triple::mips:
case llvm::Triple::mipsel: case llvm::Triple::mipsel:
VersionCondition::addPredefinedGlobalIdent("MIPS"); VersionCondition::addPredefinedGlobalIdent("MIPS");

7
gen/llvmhelpers.cpp
View file

@ -1755,10 +1755,11 @@ llvm::GlobalVariable *declareGlobal(const Loc &loc, llvm::Module &module,
llvm::Type *type, llvm::Type *type,
llvm::StringRef mangledName, llvm::StringRef mangledName,
bool isConstant, bool isThreadLocal) { bool isConstant, bool isThreadLocal) {
// No TLS support for WebAssembly; spare users from having to add __gshared // No TLS support for WebAssembly and AVR; spare users from having to add
// everywhere. // __gshared everywhere.
const auto arch = global.params.targetTriple->getArch(); const auto arch = global.params.targetTriple->getArch();
if (arch == llvm::Triple::wasm32 || arch == llvm::Triple::wasm64) if (arch == llvm::Triple::wasm32 || arch == llvm::Triple::wasm64 ||
arch == llvm::Triple::avr)
isThreadLocal = false; isThreadLocal = false;
llvm::GlobalVariable *existing = llvm::GlobalVariable *existing =

13
tests/codegen/avr.d Normal file
View file

@ -0,0 +1,13 @@
// REQUIRES: atleast_llvm400, target_AVR
// RUN: %ldc -mtriple=avr -betterC -output-ll -of=%t.ll %s && FileCheck %s < %t.ll
version (AVR) {} else static assert(0);
version (D_SoftFloat) {} else static assert(0);
// make sure TLS globals are emitted as regular __gshared globals:
// CHECK: @_D3avr13definedGlobali = global i32 123
int definedGlobal = 123;
// CHECK: @_D3avr14declaredGlobali = external global i32
extern int declaredGlobal;