mirrors/ldc
1
0
Fork 0
mirror of https://github.com/ldc-developers/ldc.git synced 2025-05-06 10:57:35 +03:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fix bit field IR storage from weird integer to i8 array (#4708)

Browse source 
Fixes #4646.
This commit is contained in:
Martin Kinkelin 2024-07-19 17:53:32 +02:00 • committed by GitHub
parent da4a6e466d
commit 866be1e8cb
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
6 changed files with 79 additions and 17 deletions
Download patch file Download diff file Expand all files Collapse all files

3
gen/dvalue.cpp
View file

@ -183,6 +183,7 @@ DRValue *DBitFieldLValue::getRVal() {
const auto sizeInBits = intType->getBitWidth();
const auto ptr = val;
LLValue *v = gIR->ir->CreateAlignedLoad(intType, ptr, llvm::MaybeAlign(1));
// TODO: byte-swap v for big-endian targets?
if (bf->type->isunsigned()) {
if (auto n = bf->bitOffset)
@ -212,6 +213,7 @@ void DBitFieldLValue::store(LLValue *value) {
llvm::APInt::getLowBitsSet(intType->getBitWidth(), bf->fieldWidth);
const auto oldVal =
gIR->ir->CreateAlignedLoad(intType, ptr, llvm::MaybeAlign(1));
// TODO: byte-swap oldVal for big-endian targets?
const auto maskedOldVal =
gIR->ir->CreateAnd(oldVal, ~(mask << bf->bitOffset));
@ -221,6 +223,7 @@ void DBitFieldLValue::store(LLValue *value) {
bfVal = gIR->ir->CreateShl(bfVal, n);
const auto newVal = gIR->ir->CreateOr(maskedOldVal, bfVal);
// TODO: byte-swap newVal for big-endian targets?
gIR->ir->CreateAlignedStore(newVal, ptr, llvm::MaybeAlign(1));
}