mirrors/ldc
1
0
Fork 0
mirror of https://github.com/ldc-developers/ldc.git synced 2025-05-01 23:50:43 +03:00
Code Issues Projects Releases Packages Wiki Activity Actions

Use nonnull and dereferenceable attributes for function params

Browse source
This commit is contained in:
Martin 2015-12-14 00:58:25 +01:00
parent 956061c3c7
commit 7fc28d8143
3 changed files with 26 additions and 14 deletions
Download patch file Download diff file Expand all files Collapse all files

34
gen/functions.cpp
View file

@ -70,7 +70,7 @@ llvm::FunctionType *DtoFunctionType(Type *type, IrFuncTy &irFty, Type *thistype,
} else {
Type *rt = f->next;
const bool byref = f->isref && rt->toBasetype()->ty != Tvoid;
AttrBuilder attrBuilder;
AttrBuilder attrs;
if (abi->returnInArg(f)) {
// sret return
@ -87,24 +87,27 @@ llvm::FunctionType *DtoFunctionType(Type *type, IrFuncTy &irFty, Type *thistype,
++nextLLArgIdx;
} else {
// sext/zext return
attrBuilder.add(DtoShouldExtend(byref ? rt->pointerTo() : rt));
attrs.add(DtoShouldExtend(byref ? rt->pointerTo() : rt));
}
newIrFty.ret = new IrFuncTyArg(rt, byref, attrBuilder);
newIrFty.ret = new IrFuncTyArg(rt, byref, attrs);
}
++nextLLArgIdx;
if (thistype) {
// Add the this pointer for member functions
AttrBuilder attrBuilder;
AttrBuilder attrs;
attrs.add(LLAttribute::NonNull);
if (isCtor) {
attrBuilder.add(LLAttribute::Returned);
attrs.add(LLAttribute::Returned);
}
newIrFty.arg_this = new IrFuncTyArg(
thistype, thistype->toBasetype()->ty == Tstruct, attrBuilder);
newIrFty.arg_this =
new IrFuncTyArg(thistype, thistype->toBasetype()->ty == Tstruct, attrs);
++nextLLArgIdx;
} else if (nesttype) {
// Add the context pointer for nested functions
newIrFty.arg_nest = new IrFuncTyArg(nesttype, false);
AttrBuilder attrs;
attrs.add(LLAttribute::NonNull);
newIrFty.arg_nest = new IrFuncTyArg(nesttype, false, attrs);
++nextLLArgIdx;
}
@ -141,27 +144,30 @@ llvm::FunctionType *DtoFunctionType(Type *type, IrFuncTy &irFty, Type *thistype,
bool passPointer = arg->storageClass & (STCref | STCout);
Type *loweredDType = arg->type;
AttrBuilder attrBuilder;
AttrBuilder attrs;
if (arg->storageClass & STClazy) {
// Lazy arguments are lowered to delegates.
Logger::println("lazy param");
auto ltf = new TypeFunction(nullptr, arg->type, 0, LINKd);
auto ltd = new TypeDelegate(ltf);
loweredDType = ltd;
} else if (!passPointer) {
} else if (passPointer) {
// ref/out
attrs.addDereferenceable(loweredDType->size());
} else {
if (abi->passByVal(loweredDType)) {
// LLVM ByVal parameters are pointers to a copy in the function
// parameters stack. The caller needs to provide a pointer to the
// original argument.
attrBuilder.addByVal(DtoAlignment(loweredDType));
attrs.addByVal(DtoAlignment(loweredDType));
passPointer = true;
} else {
// Add sext/zext as needed.
attrBuilder.add(DtoShouldExtend(loweredDType));
attrs.add(DtoShouldExtend(loweredDType));
}
}
newIrFty.args.push_back(
new IrFuncTyArg(loweredDType, passPointer, attrBuilder));
newIrFty.args.push_back(new IrFuncTyArg(loweredDType, passPointer, attrs));
newIrFty.args.back()->parametersIdx = i;
++nextLLArgIdx;
}