mirrors/ldc
1
0
Fork 0
mirror of https://github.com/ldc-developers/ldc.git synced 2025-05-04 17:11:44 +03:00
Code Issues Projects Releases Packages Wiki Activity Actions

Avoid setting always-inline for functions that contain DMD-style inline assembly. (#4631)

Browse source 
As the presence of DMD-style inline assembly in a function causes
never-inline to be set for that function.
This commit is contained in:
Harry Gillanders 2024-04-28 00:11:22 +01:00 • committed by GitHub
parent 696a18b70b
commit 48db5d5621
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
5 changed files with 66 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

17
gen/functions.cpp
View file

@ -654,7 +654,22 @@ void DtoDeclareFunction(FuncDeclaration *fdecl, const bool willDefine) {
irFunc->setNeverInline();
} else {
if (fdecl->inlining == PINLINE::always) {
irFunc->setAlwaysInline();
// If the function contains DMD-style inline assembly.
if (fdecl->hasReturnExp & 32) {
// The presence of DMD-style inline assembly in a function causes that
// function to become never-inline. So, if this function contains DMD-style
// inline assembly we'll emit an error as it can't be made always-inline.
// However, we'll make an exception for C functions, as the C standard doesn't
// actually require that `inline` functions be inlined. So, for C functions we just
// ignore the attempt to make it always-inline.
if (!fdecl->isCsymbol()) {
error(fdecl->loc,
"`%s` cannot be `pragma(inline, true)` as it contains DMD-style inline assembly",
fdecl->toPrettyChars());
}
} else {
irFunc->setAlwaysInline();
}
} else if (fdecl->inlining == PINLINE::never) {
irFunc->setNeverInline();
}