diff --git a/gen/optimizer.cpp b/gen/optimizer.cpp index ac8765aa6b..bfb471ebaf 100644 --- a/gen/optimizer.cpp +++ b/gen/optimizer.cpp @@ -135,6 +135,7 @@ static void addPassesForOptLevel(PassManager& pm) { addPass(pm, createFunctionAttrsPass()); addPass(pm, createTailCallEliminationPass()); addPass(pm, createCFGSimplificationPass()); + addPass(pm, createGVNPass()); } // -inline @@ -145,10 +146,13 @@ static void addPassesForOptLevel(PassManager& pm) { // Run some optimizations to clean up after inlining. addPass(pm, createScalarReplAggregatesPass()); addPass(pm, createInstructionCombiningPass()); + // -instcombine + gvn == devirtualization :) + addPass(pm, createGVNPass()); - // Inline again, to catch things like foreach delegates - // passed to inlined opApply's where the function wasn't - // known during the first inliner pass. + // Inline again, to catch things like now nonvirtual + // function calls, foreach delegates passed to inlined + // opApply's, etc. where the actual function being called + // wasn't known during the first inliner pass. addPass(pm, createFunctionInliningPass()); // Run clean-up again. diff --git a/gen/runtime.cpp b/gen/runtime.cpp index f13414f805..ce86dec074 100644 --- a/gen/runtime.cpp +++ b/gen/runtime.cpp @@ -329,7 +329,7 @@ static void LLVM_D_BuildRuntimeModule() std::string fname("_d_allocclass"); std::vector types; types.push_back(classInfoTy); - const llvm::FunctionType* fty = llvm::FunctionType::get(objectTy, types, false); + const llvm::FunctionType* fty = llvm::FunctionType::get(voidPtrTy, types, false); llvm::Function::Create(fty, llvm::GlobalValue::ExternalLinkage, fname, M) ->setAttributes(Attr_NoAlias); } diff --git a/runtime/internal/lifetime.d b/runtime/internal/lifetime.d index 206a256832..be78f9ce9f 100644 --- a/runtime/internal/lifetime.d +++ b/runtime/internal/lifetime.d @@ -107,7 +107,7 @@ private /** * */ -extern (C) Object _d_allocclass(ClassInfo ci) +extern (C) void* _d_allocclass(ClassInfo ci) { void* p; @@ -150,7 +150,7 @@ extern (C) Object _d_allocclass(ClassInfo ci) //(cast(byte*) p)[0 .. ci.init.length] = ci.init[]; debug(PRINTF) printf("initialization done\n"); - return cast(Object) p; + return p; } /**