mirrors/ldc
1
0
Fork 0
mirror of https://github.com/ldc-developers/ldc.git synced 2025-05-14 15:16:07 +03:00
Code Issues Projects Releases Packages Wiki Activity Actions

Account for special case of builtin TypeInfos (rt.typeinfo.*)

Browse source 
And aid in debugging by outputting the IR type names if there are type
mismatches when declaring global variables.
This commit is contained in:
Martin 2018-04-08 00:26:45 +02:00
parent 8d5a94c7b8
commit 2dea0e96ee
2 changed files with 25 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

16
gen/llvmhelpers.cpp
View file

@ -1746,6 +1746,14 @@ llvm::Constant *buildStringLiteralConstant(StringExp *se, bool zeroTerm) {
return LLConstantArray::get(at, vals);
}
static std::string llvmTypeToString(llvm::Type *type) {
std::string result;
llvm::raw_string_ostream stream(result);
stream << *type;
stream.flush();
return result;
}
llvm::GlobalVariable *declareGlobal(const Loc &loc, llvm::Module &module,
llvm::Type *type,
llvm::StringRef mangledName,
@ -1753,13 +1761,17 @@ llvm::GlobalVariable *declareGlobal(const Loc &loc, llvm::Module &module,
llvm::GlobalVariable *existing =
module.getGlobalVariable(mangledName, /*AllowInternal=*/true);
if (existing) {
if (existing->getType()->getElementType() != type ||
existing->isConstant() != isConstant ||
const auto existingType = existing->getType()->getElementType();
if (existingType != type || existing->isConstant() != isConstant ||
existing->isThreadLocal() != isThreadLocal) {
const auto existingTypeName = llvmTypeToString(existingType);
const auto newTypeName = llvmTypeToString(type);
error(loc,
"Global variable type does not match previous declaration with "
"same mangled name: `%s`",
mangledName.str().c_str());
errorSupplemental(loc, "Previous IR type: %s", existingTypeName.c_str());
errorSupplemental(loc, "New IR type: %s", newTypeName.c_str());
fatal();
}
return existing;