mirrors/ldc
1
0
Fork 0
mirror of https://github.com/ldc-developers/ldc.git synced 2025-04-29 06:30:39 +03:00
Code Issues Projects Releases Packages Wiki Activity Actions

Merge pull request #3873 from kinke/no_reverse

Browse source 
Don't reverse parameters order for extern(D)
This commit is contained in:
Martin Kinkelin 2022-03-08 17:03:17 +01:00 • committed by GitHub
parent 5ef22d1455
commit 0fd5c6ec16
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
21 changed files with 38 additions and 94 deletions
Download patch file Download diff file Expand all files Collapse all files

12
gen/functions.cpp
View file

@ -222,8 +222,6 @@ llvm::FunctionType *DtoFunctionType(Type *type, IrFuncTy &irFty, Type *thistype,
++nextLLArgIdx;
}
newIrFty.reverseParams = abi->reverseExplicitParams(f);
// let the ABI rewrite the types as necessary
abi->rewriteFunctionType(newIrFty);
@ -254,17 +252,11 @@ llvm::FunctionType *DtoFunctionType(Type *type, IrFuncTy &irFty, Type *thistype,
std::swap(argtypes[0], argtypes[1]);
}
const size_t firstExplicitArg = argtypes.size();
const size_t numExplicitLLArgs = irFty.args.size();
for (size_t i = 0; i < numExplicitLLArgs; i++) {
argtypes.push_back(irFty.args[i]->ltype);
}
// reverse params?
if (irFty.reverseParams && numExplicitLLArgs > 1) {
std::reverse(argtypes.begin() + firstExplicitArg, argtypes.end());
}
irFty.funcType =
LLFunctionType::get(irFty.ret->ltype, argtypes, isLLVMVariadic);
@ -791,9 +783,7 @@ void DtoDeclareFunction(FuncDeclaration *fdecl, const bool willDefine) {
unsigned int k = 0;
for (; iarg != func->arg_end(); ++iarg) {
size_t llExplicitIdx = irFty.reverseParams ? irFty.args.size() - k - 1 : k;
++k;
IrFuncTyArg *arg = irFty.args[llExplicitIdx];
IrFuncTyArg *arg = irFty.args[k++];
if (!fdecl->parameters || arg->parametersIdx >= fdecl->parameters->length) {
iarg->setName("unnamed");