mirrors/ldc
1
0
Fork 0
mirror of https://github.com/ldc-developers/ldc.git synced 2025-05-11 21:37:17 +03:00
Code Issues Projects Releases Packages Wiki Activity Actions

Avoid unnecessary memset when allocating array literals.

Browse source 
This completes the merge of pull request #294. Thanks a lot to
Chris Holdsworth who originally wrote the patch!

GitHub: Fixes #294.
GitHub: Fixes #141.
This commit is contained in:
David Nadlinger 2013-05-04 21:20:09 +02:00
parent f2662c3660
commit 0a376b9c71
3 changed files with 7 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
gen/arrays.cpp
View file

@ -583,7 +583,9 @@ DSliceValue* DtoNewDynArray(Loc& loc, Type* arrayType, DValue* dim, bool default
defaultInit = false; defaultInit = false;
bool zeroInit = eltType->isZeroInit(); bool zeroInit = eltType->isZeroInit();
const char* fnname = zeroInit ? "_d_newarrayT" : "_d_newarrayiT"; const char* fnname = defaultInit ?
(zeroInit ? "_d_newarrayT" : "_d_newarrayiT") :
"_d_newarrayvT";
LLFunction* fn = LLVM_D_GetRuntimeFunction(gIR->module, fnname); LLFunction* fn = LLVM_D_GetRuntimeFunction(gIR->module, fnname);
// call allocator // call allocator

2
gen/passes/GarbageCollect2Stack.cpp
View file

@ -358,7 +358,7 @@ FunctionPass *createGarbageCollect2Stack() {
GarbageCollect2Stack::GarbageCollect2Stack() GarbageCollect2Stack::GarbageCollect2Stack()
: FunctionPass(ID), : FunctionPass(ID),
AllocMemoryT(0, true, false), AllocMemoryT(0, true, false),
NewArrayVT(0, true, false, false, 1), NewArrayVT(0, true, true, false, 1),
NewArrayT(0, true, true, true, 1) NewArrayT(0, true, true, true, 1)
{ {
KnownFunctions["_d_allocmemoryT"] = &AllocMemoryT; KnownFunctions["_d_allocmemoryT"] = &AllocMemoryT;

3
gen/runtime.cpp
View file

@ -342,13 +342,16 @@ static void LLVM_D_BuildRuntimeModule()
} }
// void[] _d_newarrayT(TypeInfo ti, size_t length) // void[] _d_newarrayT(TypeInfo ti, size_t length)
// void[] _d_newarrayiT(TypeInfo ti, size_t length) // void[] _d_newarrayiT(TypeInfo ti, size_t length)
// void[] _d_newarrayvT(TypeInfo ti, size_t length)
{ {
llvm::StringRef fname("_d_newarrayT"); llvm::StringRef fname("_d_newarrayT");
llvm::StringRef fname2("_d_newarrayiT"); llvm::StringRef fname2("_d_newarrayiT");
llvm::StringRef fname3("_d_newarrayvT");
LLType *types[] = { typeInfoTy, sizeTy }; LLType *types[] = { typeInfoTy, sizeTy };
LLFunctionType* fty = llvm::FunctionType::get(voidArrayTy, types, false); LLFunctionType* fty = llvm::FunctionType::get(voidArrayTy, types, false);
llvm::Function::Create(fty, llvm::GlobalValue::ExternalLinkage, fname, M); llvm::Function::Create(fty, llvm::GlobalValue::ExternalLinkage, fname, M);
llvm::Function::Create(fty, llvm::GlobalValue::ExternalLinkage, fname2, M); llvm::Function::Create(fty, llvm::GlobalValue::ExternalLinkage, fname2, M);
llvm::Function::Create(fty, llvm::GlobalValue::ExternalLinkage, fname3, M);
} }
// void[] _d_newarraymT(TypeInfo ti, size_t length, size_t* dims) // void[] _d_newarraymT(TypeInfo ti, size_t length, size_t* dims)
// void[] _d_newarraymiT(TypeInfo ti, size_t length, size_t* dims) // void[] _d_newarraymiT(TypeInfo ti, size_t length, size_t* dims)