mirrors/hugo
1
0
Fork 0
mirror of https://github.com/gohugoio/hugo.git synced 2025-04-26 13:40:38 +03:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

modules: Fix potential infinite loop in module collection

Browse source 
Fixes #12407
This commit is contained in:
Bjørn Erik Pedersen 2024-04-22 10:39:36 +02:00
parent 4e483f5d4a
commit f40f50ead0
1 changed files with 4 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

5
modules/collect.go
View file

@ -261,7 +261,10 @@ func (c *collector) add(owner *moduleAdapter, moduleImport Import) (*moduleAdapt
// This will select the latest release-version (not beta etc.). // This will select the latest release-version (not beta etc.).
versionQuery = "upgrade" versionQuery = "upgrade"
} }
if err := c.Get(fmt.Sprintf("%s@%s", modulePath, versionQuery)); err != nil {
// Note that we cannot use c.Get for this, as that may
// trigger a new module collection and potentially create a infinite loop.
if err := c.get(fmt.Sprintf("%s@%s", modulePath, versionQuery)); err != nil {
return nil, err return nil, err
} }
if err := c.loadModules(); err != nil { if err := c.loadModules(); err != nil {