mirrors/hugo
1
0
Fork 0
mirror of https://github.com/gohugoio/hugo.git synced 2025-04-27 22:21:07 +03:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

Update test logs for uniformity and consistency

Browse source 
Many minor fixes to make test logs more consistent and correct a
mispelling.

Standardize on "[%i] got X but expected Y" for log messages. Using
a consistent layout makes it easier to read the test results. This
was mostly changing "Got" to "got". Swapped the order of values on
several calls to bring them in line with the convention.

A few log messages had a sequence number added to identify the
exact scenario that failed. Otherwise, there would be no way to
ascertain which failed When there are many scenarios.

Correct spelling of "expected."

Fixes #1028
Merged be2097e1ad

[close #1040]
This commit is contained in:
bep 2015-04-05 21:03:16 +02:00 • committed by spf13
parent 2b91b480d0
commit a52e508d46
7 changed files with 26 additions and 25 deletions
Download patch file Download diff file Expand all files Collapse all files

12
helpers/general_test.go
View file

@ -28,7 +28,7 @@ func TestGuessType(t *testing.T) {
} {
result := GuessType(this.in)
if result != this.expect {
t.Errorf("[%d] GuessType guessed wrong, expected %s, got %s", i, this.expect, result)
t.Errorf("[%d] got %s but expected %s", i, result, this.expect)
}
}
}
@ -109,7 +109,7 @@ func TestReaderContains(t *testing.T) {
for i, this := range append(containsBenchTestData, containsAdditionalTestData...) {
result := ReaderContains(StringToReader(this.v1), this.v2)
if result != this.expect {
t.Errorf("[%d] Got %t but expected %t", i, result, this.expect)
t.Errorf("[%d] got %t but expected %t", i, result, this.expect)
}
}
@ -123,7 +123,7 @@ func BenchmarkReaderContains(b *testing.B) {
for i, this := range containsBenchTestData {
result := ReaderContains(StringToReader(this.v1), this.v2)
if result != this.expect {
b.Errorf("[%d] Got %t but expected %t", i, result, this.expect)
b.Errorf("[%d] got %t but expected %t", i, result, this.expect)
}
}
}
@ -140,7 +140,7 @@ func _BenchmarkReaderContains(b *testing.B) {
}
result := bytes.Contains(bs, this.v2)
if result != this.expect {
b.Errorf("[%d] Got %t but expected %t", i, result, this.expect)
b.Errorf("[%d] got %t but expected %t", i, result, this.expect)
}
}
}
@ -167,10 +167,10 @@ func TestInStringArrayCaseSensitive(t *testing.T) {
{"Albert", true},
{"ALBERT", false},
}
for _, in := range data {
for i, in := range data {
output := InStringArray(array, in.input)
if output != in.expected {
t.Errorf("TestInStringArrayCase failed. Expected %t. Got %t.", in.expected, output)
t.Errorf("[%d] got %t but expected %t", i, output, in.expected)
}
}
}