mirrors/dmd
1
0
Fork 0
mirror of https://github.com/dlang/dmd.git synced 2025-04-29 14:40:12 +03:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

Minor: Move a test from traits compiles to fail compilation

Browse source 
It's better to have tests in fail_compilation, as they ensure the
error message is correct (the test fails for the right reason),
and it makes it easier to find in which condition a certain error triggers.
This commit is contained in:
Geod24 2021-11-01 09:13:30 +09:00 • committed by The Dlang Bot
parent 883048c55f
commit fd8c50ba0c
2 changed files with 22 additions and 17 deletions
Download patch file Download diff file Expand all files Collapse all files

17
test/compilable/test4090.d
View file

@ -12,9 +12,6 @@ void test4090a()
// inference + qualifier + ref // inference + qualifier + ref
foreach ( ref x; arr) static assert(is(typeof(x) == int)); foreach ( ref x; arr) static assert(is(typeof(x) == int));
foreach ( const ref x; arr) static assert(is(typeof(x) == const int)); foreach ( const ref x; arr) static assert(is(typeof(x) == const int));
static assert(!__traits(compiles, {
foreach (immutable ref x; arr) {}
}));
// with exact type + qualifier // with exact type + qualifier
foreach ( int x; arr) static assert(is(typeof(x) == int)); foreach ( int x; arr) static assert(is(typeof(x) == int));
@ -24,25 +21,11 @@ void test4090a()
// with exact type + qualifier + ref // with exact type + qualifier + ref
foreach ( ref int x; arr) static assert(is(typeof(x) == int)); foreach ( ref int x; arr) static assert(is(typeof(x) == int));
foreach ( const ref int x; arr) static assert(is(typeof(x) == const int)); foreach ( const ref int x; arr) static assert(is(typeof(x) == const int));
static assert(!__traits(compiles, {
foreach (immutable ref int x; arr) {}
}));
// convertible type + qualifier // convertible type + qualifier
foreach ( double x; arr) static assert(is(typeof(x) == double)); foreach ( double x; arr) static assert(is(typeof(x) == double));
foreach ( const double x; arr) static assert(is(typeof(x) == const double)); foreach ( const double x; arr) static assert(is(typeof(x) == const double));
foreach (immutable double x; arr) static assert(is(typeof(x) == immutable double)); foreach (immutable double x; arr) static assert(is(typeof(x) == immutable double));
// convertible type + qualifier + ref
static assert(!__traits(compiles, {
foreach ( ref double x; arr) {}
}));
static assert(!__traits(compiles, {
foreach ( const ref double x; arr) {}
}));
static assert(!__traits(compiles, {
foreach (immutable ref double x; arr) {}
}));
} }
// for the immutable elements // for the immutable elements
{ {

22
test/fail_compilation/foreach2.d Normal file
View file

@ -0,0 +1,22 @@
/*
TEST_OUTPUT:
---
fail_compilation/foreach2.d(15): Error: argument type mismatch, `int` to `ref immutable(int)`
fail_compilation/foreach2.d(16): Error: argument type mismatch, `int` to `ref immutable(int)`
fail_compilation/foreach2.d(19): Error: argument type mismatch, `int` to `ref double`
fail_compilation/foreach2.d(20): Error: argument type mismatch, `int` to `ref const(double)`
fail_compilation/foreach2.d(21): Error: argument type mismatch, `int` to `ref immutable(double)`
---
*/
void test4090 ()
{
// From https://issues.dlang.org/show_bug.cgi?id=4090
int[] arr = [1,2,3];
foreach (immutable ref x; arr) {}
foreach (immutable ref int x; arr) {}
// convertible type + qualifier + ref
foreach ( ref double x; arr) {}
foreach ( const ref double x; arr) {}
foreach (immutable ref double x; arr) {}
}