mirrors/dmd
1
0
Fork 0
mirror of https://github.com/dlang/dmd.git synced 2025-04-26 13:10:12 +03:00
Code Issues Projects Releases Packages Wiki Activity Actions 5

Update CONTRIBUTING.md

Browse source 
Co-authored-by: Mathias LANG <geod24@gmail.com>
This commit is contained in:
Walter Bright 2021-05-31 21:28:30 -07:00 • committed by GitHub
parent 1882740d88
commit f140e09b88
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

10
CONTRIBUTING.md
View file

@ -82,12 +82,12 @@ program, add enhancements, or fix bugs.
- Refactorings must come with a rationale as to why it makes the code better.
- Break up larger refactorings into a series of self-contained PRs rather than one gigantic one.
- Large refactorings should be done in incremental steps that are easy to review.
- Significant refactorings that include bug fixes and/or enhancements will be rejected with a
request to submit bug fixes and enhancements as separate PRs. Putting them as separate commits
is not sufficient. Refactorings will be reviewed on their own merits, not conflated with
other changes.
- When a refactoring is broken down into multiple PRs, it is acceptable to provide a rationale in the first PR and link to it in subsequent PR.
- Pull requests that do non-trivial refactorings should not include other changes, such as new feature or bug fix.
While submitting multiple dependent pull requests can be done to help the reviewers judge of the need for a refactoring, any refactoring will be assessed on its own merit.
## DMD Best Practices