mirrors/dmd
1
0
Fork 0
mirror of https://github.com/dlang/dmd.git synced 2025-04-26 13:10:12 +03:00
Code Issues Projects Releases Packages Wiki Activity Actions 5

iasm.d: refactor tryExpressionToOperand() to clarify its behavior

Browse source
This commit is contained in:
Walter Bright 2020-08-23 18:47:10 -07:00 • committed by The Dlang Bot
parent 29a39c6a3e
commit ebca098f78
1 changed files with 7 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

13
src/dmd/iasmdmd.d
View file

@ -4380,6 +4380,8 @@ void asm_primary_exp(out OPND o1)
}
}
TOK e2o = tryExpressionToOperand(e, o1, s);
if (e2o == TOK.error)
return;
if (e2o == TOK.const_)
goto Lpost;
}
@ -4469,24 +4471,23 @@ void asm_primary_exp(out OPND o1)
* Params:
* e = Input. The expression to evaluate. This can be an arbitrarily complex expression
* but it must either represent a constant after CTFE or give a higher level variable.
* o1 = Output. The ASM operand to define from `e`.
* s = Output. The symbol when `e` represents a variable.
* o1 = if `e` turns out to be a constant, `o1` is set to reflect that
* s = if `e` turns out to be a variable, `s` is set to reflect that
*
* Returns:
* `TOK.variable` if `s` was set to a variable,
* `TOK.const_` if `e` was evaluated to a valid constant,
* `TOK.error` otherwise.
*/
TOK tryExpressionToOperand(Expression e, ref OPND o1, ref Dsymbol s)
TOK tryExpressionToOperand(Expression e, out OPND o1, out Dsymbol s)
{
Scope *sc = asmstate.sc.startCTFE();
e = e.expressionSemantic(sc);
sc.endCTFE();
e = e.ctfeInterpret();
if (e.op == TOK.variable)
if (auto ve = e.isVarExp())
{
VarExp v = cast(VarExp) e;
s = v.var;
s = ve.var;
return TOK.variable;
}
if (e.isConst())