mirrors/dmd
1
0
Fork 0
mirror of https://github.com/dlang/dmd.git synced 2025-04-26 05:00:16 +03:00
Code Issues Projects Releases Packages Wiki Activity Actions 5

detail optimize switch compares (#21163)

Browse source
This commit is contained in:
Walter Bright 2025-04-06 23:09:34 -07:00 • committed by GitHub
parent a03aa271f8
commit b2926b6b2a
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 18 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

26
compiler/src/dmd/backend/x86/cod3.d
View file

@ -1598,18 +1598,28 @@ struct CaseVal
* Generate comparison of [reg2,reg] with val * Generate comparison of [reg2,reg] with val
*/ */
@trusted @trusted
private void cmpval(CGstate cg, ref CodeBuilder cdb, targ_llong val, uint sz, reg_t reg, reg_t reg2, reg_t sreg) private void cmpval(CGstate cg, ref CodeBuilder cdb, ulong val, uint sz, reg_t reg, reg_t reg2, reg_t sreg)
{ {
if (cg.AArch64) if (cg.AArch64)
{ {
// TODO AArch64 use CMP https://www.scs.stanford.edu/~zyedidia/arm64/cmp_subs_addsub_imm.html
assert(sreg == NOREG); assert(sreg == NOREG);
regm_t retregs = cg.allregs & ~mask(reg); if (val <= 0xFFF || val >= 0x1000 && val <= 0xFFF000)
sreg = allocreg(cdb,retregs,TYint); {
movregconst(cdb,sreg,val,sz == 8 ? 64 : 0); ubyte sh = val >= 0x1000;
getregsNoSave(retregs); uint imm12 = cast(uint)(sh ? val >> 12 : val);
assert(reg2 == NOREG); assert((imm12 & ~0xFFF) == 0);
cdb.gen1(INSTR.cmp_shift(sz == 8, reg, 0, 0, sreg)); // CMP sreg,reg // https://www.scs.stanford.edu/~zyedidia/arm64/cmp_subs_addsub_imm.html
cdb.gen1(INSTR.cmp_imm(sz == 8, sh, imm12, reg)); // CMP reg,#imm12{, shift}
}
else
{
regm_t retregs = cg.allregs & ~mask(reg);
sreg = allocreg(cdb,retregs,TYint);
movregconst(cdb,sreg,val,sz == 8 ? 64 : 0);
getregsNoSave(retregs);
assert(reg2 == NOREG);
cdb.gen1(INSTR.cmp_shift(sz == 8, reg, 0, 0, sreg)); // CMP sreg,reg
}
} }
else if (I64 && sz == 8) else if (I64 && sz == 8)
{ {