mirrors/dmd
1
0
Fork 0
mirror of https://github.com/dlang/dmd.git synced 2025-04-25 20:50:41 +03:00
Code Issues Projects Releases Packages Wiki Activity Actions

Refactor: Remove Unused Hooks in dinterpret.d (#21022)

Browse source 
- Removed references to _d_arrayappendcTX, _d_newThrowable, and _d_arrayappendT.
- Ensured test cases pass after deletion.
- Left _d_arrayctor and _d_arraysetctor untouched for future semantic phase changes.
This commit is contained in:
Shivang Shukla 2025-03-18 14:09:32 +05:30 • committed by GitHub
parent 5caf886afb
commit a7e2b2e17b
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 0 additions and 61 deletions
Download patch file Download diff file Expand all files Collapse all files

61
compiler/src/dmd/dinterpret.d
View file

@ -1027,12 +1027,6 @@ Expression interpretStatement(UnionExp* pue, Statement s, InterState* istate)
* assigning a larger array into a smaller one, such as:
* `a = [1, 2], a ~= [3]` => `[1, 2] ~= [3]` => `[1, 2] = [1, 2, 3]`
*/
if (isRuntimeHook(s.exp, Id._d_arrayappendT) || isRuntimeHook(s.exp, Id._d_arrayappendTTrace))
{
auto rs = new ReturnStatement(s.loc, e);
visitReturn(rs);
return;
}
// Disallow returning pointers to stack-allocated variables (bug 7876)
if (!stopPointersEscaping(s.loc, e))
@ -5001,61 +4995,6 @@ public:
printf("%s CommaExp::interpret() %s\n", e.loc.toChars(), e.toChars());
}
bool isNewThrowableHook()
{
auto de = e.e1.isDeclarationExp();
if (de is null)
return false;
auto vd = de.declaration.isVarDeclaration();
if (vd is null)
return false;
auto ei = vd._init.isExpInitializer();
if (ei is null)
return false;
auto ce = ei.exp.isConstructExp();
if (ce is null)
return false;
return isRuntimeHook(ce.e2, Id._d_newThrowable) !is null;
}
if (auto ce = isRuntimeHook(e.e1, Id._d_arrayappendcTX))
{
// In expressionsem.d `arr ~= elem` was lowered to
// `_d_arrayappendcTX(arr, elem), arr[arr.length - 1] = elem, elem;`.
// The following code will rewrite it back to `arr ~= elem`
// and then interpret that expression.
assert(ce.arguments.length == 2);
auto arr = (*ce.arguments)[0];
auto elem = e.e2.isConstructExp().e2;
assert(elem);
auto cae = new CatAssignExp(e.loc, arr, elem);
cae.type = arr.type;
result = interpret(cae, istate);
return;
}
else if (isNewThrowableHook())
{
// In expressionsem.d `throw new Exception(args)` was lowered to
// `throw (tmp = _d_newThrowable!Exception(), tmp.ctor(args), tmp)`.
// The following code will rewrite it back to `throw new Exception(args)`
// and then interpret this expression instead.
auto ce = e.e2.isCallExp();
assert(ce);
auto ne = new NewExp(e.loc, null, null, e.type, ce.arguments);
ne.type = e.e1.type;
result = interpret(ne, istate);
return;
}
// If it creates a variable, and there's no context for
// the variable to be created in, we need to create one now.
InterState istateComma;