mirrors/dmd
1
0
Fork 0
mirror of https://github.com/dlang/dmd.git synced 2025-04-26 21:21:48 +03:00
Code Issues Projects Releases Packages Wiki Activity Actions 10

Improve override suggestions to exclude final methods (#21138)

Browse source
This commit is contained in:
Abul Hossain Khan 2025-04-07 11:39:25 +05:30 • committed by GitHub
parent 63ed7154b7
commit a03aa271f8
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 56 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

40
compiler/src/dmd/funcsem.d
View file

@ -986,6 +986,46 @@ void funcDeclarationSemantic(Scope* sc, FuncDeclaration funcdecl)
errorSupplemental(fd.loc, "Function `%s` contains errors in its declaration, therefore it cannot be correctly overridden",
fd.toPrettyChars());
}
else if (fd.isFinalFunc())
{
// When trying to override a final method, don't suggest it as a candidate(Issue #19613)
.error(funcdecl.loc, "%s `%s` does not override any function", funcdecl.kind, funcdecl.toPrettyChars);
// Look for a non-final method with the same name to suggest as an alternative
auto cdparent = fd.parent ? fd.parent.isClassDeclaration() : null;
if (cdparent)
{
Dsymbol nonFinalAlt = null;
auto overloadableSyms = cdparent.symtab.lookup(fd.ident);
if (overloadableSyms)
{
// Check each overload to find one that's not final
overloadApply(overloadableSyms, (Dsymbol s)
{
if (auto funcAlt = s.isFuncDeclaration())
{
if (funcAlt != fd && !funcAlt.isFinalFunc())
{
nonFinalAlt = funcAlt;
return 1;
}
}
return 0;
});
// Provide a helpful suggestion if we found a viable alternative
if (nonFinalAlt)
{
auto funcAlt = nonFinalAlt.isFuncDeclaration();
OutBuffer buf2;
functionToBufferFull(cast(TypeFunction)(funcAlt.type), buf2,
new Identifier(funcAlt.toPrettyChars()), hgs, null);
errorSupplemental(funcdecl.loc, "Did you mean to override `%s`?", buf2.peekChars());
}
}
}
}
else
{
functionToBufferFull(cast(TypeFunction)(fd.type), buf1,

16
compiler/test/fail_compilation/fix19613.d Normal file
View file

@ -0,0 +1,16 @@
/*
TEST_OUTPUT:
---
fail_compilation/fix19613.d(15): Error: function `fix19613.B.a` cannot override `final` function `fix19613.A.a`
fail_compilation/fix19613.d(15): Error: function `fix19613.B.a` does not override any function
fail_compilation/fix19613.d(15): Did you mean to override `void fix19613.A.a(string)`?
---
*/
class A {
final void a(int) {}
void a(string) {}
}
class B : A {
override void a(int) {}
}