mirrors/dmd
1
0
Fork 0
mirror of https://github.com/dlang/dmd.git synced 2025-04-26 13:10:12 +03:00
Code Issues Projects Releases Packages Wiki Activity Actions 5

Revert "Enable -preview=fieldwise by default"

Browse source 
This reverts commit 6a7bd45a8e.

PR #17495 was originally merged in an incomplete state. Since there are
non-trivial obstacles to completing it, revert the incomplete changes
instead.

See PR #20670 for more information.
This commit is contained in:
Paul Backus 2025-01-09 13:38:03 -05:00
parent 69664b922d
commit 99b4a5dc76
4 changed files with 2 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

8
changelog/dmd.fieldwise.dd
View file

@ -1,8 +0,0 @@
`-preview=fieldwise` is now enabled by default
This fixes a bug that affected some struct comparisons using the `==` operator.
For more information, see [the entry for `-preview=fieldwise` in the 2.085.0
changelog](https://dlang.org/changelog/2.085.0.html#no-cmpsb).
The new `-revert=fieldwise` switch can be used to disable the bug fix and
restore the original behavior of the `==` operator.

4
compiler/src/dmd/cli.d
View file

@ -944,8 +944,6 @@ dmd -cov -unittest myprog.d
"https://github.com/dlang/DIPs/blob/master/DIPs/other/DIP1000.md"),
Feature("intpromote", "fix16997", "revert integral promotions for unary + - ~ operators"),
Feature("dtorfields", "dtorFields", "don't destruct fields of partially constructed objects"),
Feature("fieldwise", "fieldwise", "don't use fieldwise comparisons for struct equality",
"https://dlang.org/changelog/2.085.0.html#no-cmpsb"),
];
/// Returns all available previews
@ -966,7 +964,7 @@ dmd -cov -unittest myprog.d
Feature("bitfields", "bitfields", "add C-like bitfields",
"https://github.com/dlang/dlang.org/pull/3190"),
Feature("fieldwise", "fieldwise", "use fieldwise comparisons for struct equality",
"https://dlang.org/changelog/2.085.0.html#no-cmpsb", false, false),
"https://dlang.org/changelog/2.085.0.html#no-cmpsb"),
Feature("fixAliasThis", "fixAliasThis",
"when a symbol is resolved, check alias this scope before going to upper scopes",
"https://github.com/dlang/dmd/pull/8885"),

1
compiler/test/compilable/previewhelp.d
View file

@ -10,6 +10,7 @@ Upcoming language changes listed by -preview=name:
=dip1008 implement @nogc Throwable DIP (https://github.com/dlang/DIPs/blob/master/DIPs/other/DIP1008.md)
=dip1021 implement Mutable Function Arguments DIP (https://github.com/dlang/DIPs/blob/master/DIPs/accepted/DIP1021.md)
=bitfields add C-like bitfields (https://github.com/dlang/dlang.org/pull/3190)
=fieldwise use fieldwise comparisons for struct equality (https://dlang.org/changelog/2.085.0.html#no-cmpsb)
=fixAliasThis when a symbol is resolved, check alias this scope before going to upper scopes (https://github.com/dlang/dmd/pull/8885)
=rvaluerefparam enable rvalue arguments to ref parameters (https://gist.github.com/andralex/e5405a5d773f07f73196c05f8339435a)
=safer more safety checks by default (https://github.com/WalterBright/documents/blob/38f0a846726b571f8108f6e63e5e217b91421c86/safer.md)

1
compiler/test/compilable/reverthelp.d
View file

@ -9,6 +9,5 @@ Revertable language changes listed by -revert=name:
=dip1000 revert DIP1000 changes (Scoped Pointers) (https://github.com/dlang/DIPs/blob/master/DIPs/other/DIP1000.md)
=intpromote revert integral promotions for unary + - ~ operators
=dtorfields don't destruct fields of partially constructed objects
=fieldwise don't use fieldwise comparisons for struct equality (https://dlang.org/changelog/2.085.0.html#no-cmpsb)
----
*/