mirrors/dmd
1
0
Fork 0
mirror of https://github.com/dlang/dmd.git synced 2025-04-28 22:20:37 +03:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

fix Issue 23715 - ImportC: No rejection of _Thread_local variables declared at function scope without 'static' as per C11 6.2.4-5 (#15094)

Browse source
This commit is contained in:
Walter Bright 2023-04-10 16:53:38 -07:00 • committed by GitHub
parent b571a1a118
commit 5cd6f80d06
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 19 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

6
compiler/src/dmd/cparse.d
View file

@ -2544,6 +2544,12 @@ final class CParser(AST) : Parser!AST
error("`inline` and `_Noreturn` function specifiers not allowed for `_Thread_local`"); error("`inline` and `_Noreturn` function specifiers not allowed for `_Thread_local`");
scw &= ~scwx; scw &= ~scwx;
} }
if (level == LVL.local &&
scw & (SCW.x_Thread_local) && !(scw & (SCW.xstatic | SCW.xextern)))
{
error("`_Thread_local` in block scope must be accompanied with `static` or `extern`"); // C11 6.7.1-3
scw &= ~scwx;
}
if (level & (LVL.parameter | LVL.prototype) && if (level & (LVL.parameter | LVL.prototype) &&
scw & ~SCW.xregister) scw & ~SCW.xregister)
{ {

2
compiler/test/compilable/testcstuff1.c
View file

@ -277,7 +277,7 @@ void test2()
typedef int TI; typedef int TI;
//extern int ei; //extern int ei;
static int si; static int si;
_Thread_local int tli; static _Thread_local int tli;
int __declspec(thread) tlj; int __declspec(thread) tlj;
auto int ai; auto int ai;
register int reg; register int reg;

12
compiler/test/fail_compilation/test23715.i Normal file
View file

@ -0,0 +1,12 @@
/* TEST_OUTPUT:
---
fail_compilation/test23715.i(11): Error: `_Thread_local` in block scope must be accompanied with `static` or `extern`
---
*/
// https://issues.dlang.org/show_bug.cgi?id=23715
void test2()
{
_Thread_local int tli;
}