mirrors/dmd
1
0
Fork 0
mirror of https://github.com/dlang/dmd.git synced 2025-04-25 20:50:41 +03:00
Code Issues Projects Releases Packages Wiki Activity Actions

Improve fix: #20867 ICE on final switch forward referencing its enum. (#21097)

Browse source 
* Mark C enums as semantic2done to prevent segfaults in final switch

* Added corresponding test case
This commit is contained in:
Abul Hossain Khan 2025-03-28 14:43:12 +05:30 • committed by GitHub
parent 21cfefc9d1
commit 228f8dbcea
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 35 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

4
compiler/src/dmd/importc.d
View file

@ -751,6 +751,8 @@ void cEnumSemantic(Scope* sc, EnumDeclaration ed)
}
ed.memtype = commonType;
ed.semanticRun = PASS.semanticdone;
// Set semantic2done to mark C enums as fully processed
// Prevents issues with final switch statements that reference C enums
ed.semanticRun = PASS.semantic2done;
return;
}

13
compiler/test/compilable/imports/cstuff3.c
View file

@ -4,3 +4,16 @@ int squared(int a)
{
return a * a;
}
/* test case for issue #21094 */
typedef enum upng_error {
UPNG_EOK = 0, /* success (no error) */
UPNG_ENOMEM = 1, /* memory allocation failed */
UPNG_ENOTFOUND = 2, /* resource not found (file missing) */
UPNG_ENOTPNG = 3, /* image data does not have a PNG header */
UPNG_EMALFORMED = 4, /* image data is not a valid PNG image */
UPNG_EUNSUPPORTED = 5, /* critical PNG chunk type is not supported */
UPNG_EUNINTERLACED = 6, /* image interlacing is not supported */
UPNG_EUNFORMAT = 7, /* image color format is not supported */
UPNG_EPARAM = 8 /* invalid parameter to method call */
} upng_error;

19
compiler/test/compilable/testcstuff3.d
View file

@ -2,3 +2,22 @@
import imports.cstuff3;
static assert(squared(4) == 16);
/* test case for issue #21094 */
string enum_to_str(E)(E v) if (is(E == enum))
{
final switch (v) with(E)
{
static foreach (m; __traits(allMembers, E))
{
case mixin(m):
return m;
}
}
}
void testEnumSwitch()
{
auto str = enum_to_str(UPNG_EOK);
assert(str == "UPNG_EOK");
}