mirrors/dmd
1
0
Fork 0
mirror of https://github.com/dlang/dmd.git synced 2025-04-25 20:50:41 +03:00
Code Issues Projects Releases Packages Wiki Activity Actions

feat(test): Add DWARF_VERIFY flag on DWARF tests (#13754)

Browse source 
* ci(cirrusci): add llvm package

Signed-off-by: Luís Ferreira <contact@lsferreira.net>

* feat(test): Add DWARF_VERIFY flag on DWARF tests

DWARF readers and debuggers tend to ignore errors and try to proceed as much as
possible. objdump dumping the tags, doesn't necessarily mean that the DWARF
abbreviations are correct -- e.g. the reader could halt in the end, with the
last abbreviation, in which the output test can't verify. Introducing a DWARF
verifier is a good way to check conformancy with the standard.

Signed-off-by: Luís Ferreira <contact@lsferreira.net>
This commit is contained in:
Luís Ferreira 2022-03-08 12:04:15 +00:00 • committed by GitHub
parent 89a75886d1
commit 1bec274d82
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
10 changed files with 36 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

7
ci/cirrusci.sh
View file

@ -16,7 +16,7 @@ if [ -z ${HOST_DMD+x} ] ; then echo "Variable 'HOST_DMD' needs to be set."; exit
if [ "$OS_NAME" == "linux" ]; then
export DEBIAN_FRONTEND=noninteractive
packages="git-core make g++ gdb gnupg curl libcurl4 tzdata zip unzip xz-utils"
packages="git-core make g++ gdb gnupg curl libcurl4 tzdata zip unzip xz-utils llvm"
if [ "$MODEL" == "32" ]; then
dpkg --add-architecture i386
packages="$packages g++-multilib libcurl4:i386"
@ -30,9 +30,9 @@ if [ "$OS_NAME" == "linux" ]; then
elif [ "$OS_NAME" == "darwin" ]; then
# required for dlang install.sh
brew update-reset
brew install gnupg libarchive xz
brew install gnupg libarchive xz llvm
elif [ "$OS_NAME" == "freebsd" ]; then
packages="git gmake"
packages="git gmake devel/llvm12"
if [ "$HOST_DMD" == "dmd-2.079.0" ] ; then
packages="$packages lang/gcc9"
fi
@ -40,4 +40,5 @@ elif [ "$OS_NAME" == "freebsd" ]; then
# replace default make by GNU make
rm /usr/bin/make
ln -s /usr/local/bin/gmake /usr/bin/make
ln -s /usr/local/bin/llvm-dwarfdump12 /usr/bin/llvm-dwarfdump
fi

4
ci/run.sh
View file

@ -33,6 +33,10 @@ if [ "$OS_NAME" == "linux" ]; then
NM="nm --print-size"
else
NM=nm
if [ "$OS_NAME" == "darwin" ]; then
export PATH="/usr/local/opt/llvm/bin:$PATH"
fi
fi
# clone a repo

8
test/dshell/dwarf.d
View file

@ -36,7 +36,6 @@ int main()
if (sysObjdump.status)
return DISABLED;
double objdumpVersion;
try
{
@ -97,6 +96,12 @@ int main()
run("objdump -W " ~ exe, objdump_file);
objdump_file.close();
auto llvmDwarfdump = executeShell("llvm-dwarfdump --version");
try {
if (!llvmDwarfdump.status && requirements["DWARF_VERIFY"].to!bool)
run("llvm-dwarfdump --verify " ~ exe);
} catch (ConvException e) { }
// Objdump excepted results
string excepted_results_file = extra_dwarf_dir ~ "excepted_results"
~ slash ~ filename ~ ".txt";
@ -137,6 +142,7 @@ string[string] getRequirements(string dfile)
// Initialize to an empty string to prevent RangeViolation exceptions.
foreach (req; ["EXTRA_ARGS", "MIN_OBJDUMP_VERSION"])
result[req] = "";
result["DWARF_VERIFY"] = "true";
bool begin;

3
test/dshell/extra-files/dwarf/fix21160.d
View file

@ -1,5 +1,8 @@
/*
EXTRA_ARGS: -gdwarf=4
// Issue https://issues.dlang.org/show_bug.cgi?id=22855
DWARF_VERIFY: false
*/
void main() {}

3
test/dshell/extra-files/dwarf/fix22426.d
View file

@ -1,5 +1,8 @@
/*
EXTRA_ARGS: -gdwarf=5 -main
// Issue https://issues.dlang.org/show_bug.cgi?id=22855
DWARF_VERIFY: false
*/
noreturn noret()

3
test/dshell/extra-files/dwarf/fix22471.d
View file

@ -1,4 +1,7 @@
/*
EXTRA_ARGS: -g -defaultlib= -main -c
// Issue https://issues.dlang.org/show_bug.cgi?id=22856
DWARF_VERIFY: false
*/

3
test/dshell/extra-files/dwarf/fix22508.d
View file

@ -1,5 +1,8 @@
/*
EXTRA_ARGS: -g -defaultlib= -main -c
// Issue https://issues.dlang.org/show_bug.cgi?id=22856
DWARF_VERIFY: false
*/
int[string] istr_a;

3
test/dshell/extra-files/dwarf/immutable.d
View file

@ -1,6 +1,9 @@
/*
EXTRA_ARGS: -gdwarf=5
MIN_OBJDUMP_VERSION: 2.30
// Issue https://issues.dlang.org/show_bug.cgi?id=22855
DWARF_VERIFY: false
*/
void main()

3
test/dshell/extra-files/dwarf/immutableVoid.d
View file

@ -1,6 +1,9 @@
/*
EXTRA_ARGS: -gdwarf=5
MIN_OBJDUMP_VERSION: 2.30
// Issue https://issues.dlang.org/show_bug.cgi?id=22855
DWARF_VERIFY: false
*/
void main()

3
test/dshell/extra-files/dwarf/testVersion.d
View file

@ -1,5 +1,8 @@
/*
EXTRA_ARGS: -gdwarf=5
// Issue https://issues.dlang.org/show_bug.cgi?id=22855
DWARF_VERIFY: false
*/
void main() {}