mirrors/dmd
1
0
Fork 0
mirror of https://github.com/dlang/dmd.git synced 2025-04-27 21:51:03 +03:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

Fix #21105: Is-expressions should not generate unnecessary code for lowerings (#21106)

Browse source 
treat as if compiling with __traits(compiles)
This commit is contained in:
Rainer Schuetze 2025-03-29 01:36:10 +01:00 • committed by GitHub
parent cfa763d301
commit 13d0a42ad5
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
4 changed files with 15 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
compiler/src/dmd/dscope.d
View file

@ -64,7 +64,7 @@ private extern (D) struct BitFields
bool inTemplateConstraint; /// inside template constraint bool inTemplateConstraint; /// inside template constraint
Contract contract; Contract contract;
bool ctfe; /// inside a ctfe-only expression bool ctfe; /// inside a ctfe-only expression
bool traitsCompiles; /// inside __traits(compile) bool traitsCompiles; /// inside __traits(compile) or is-expression
/// ignore symbol visibility /// ignore symbol visibility
/// https://issues.dlang.org/show_bug.cgi?id=15907 /// https://issues.dlang.org/show_bug.cgi?id=15907
bool ignoresymbolvisibility; bool ignoresymbolvisibility;

1
compiler/src/dmd/expressionsem.d
View file

@ -7304,6 +7304,7 @@ private extern (C++) final class ExpressionSemanticVisitor : Visitor
sc2.tinst = null; sc2.tinst = null;
sc2.minst = null; sc2.minst = null;
sc2.fullinst = true; sc2.fullinst = true;
sc2.traitsCompiles = true;
Type t = dmd.typesem.trySemantic(e.targ, e.loc, sc2); Type t = dmd.typesem.trySemantic(e.targ, e.loc, sc2);
sc2.pop(); sc2.pop();
if (!t) // errors, so condition is false if (!t) // errors, so condition is false

2
compiler/test/compilable/extra-files/vcg-ast.d.cg
View file

@ -106,6 +106,8 @@ template imported()
import imported = imports.vcg_ast_import; import imported = imports.vcg_ast_import;
} }
alias myImport = vcg_ast_import; alias myImport = vcg_ast_import;
enum bool compiles = true;
enum bool isexp = true;
R!int R!int
{ {
struct _R struct _R

11
compiler/test/compilable/vcg-ast.d
View file

@ -75,3 +75,14 @@ template imported()
} }
alias myImport = imported!(); alias myImport = imported!();
// https://github.com/dlang/dmd/issues/21105
enum compiles = __traits(compiles,{
int[] arr;
arr ~= 1;
});
enum isexp = is(typeof({
int[] arr;
arr ~= 1;
}));