mirrors/dmd
1
0
Fork 0
mirror of https://github.com/dlang/dmd.git synced 2025-04-25 12:40:11 +03:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fix wrong 'not an lvalue' error when assigning to sequence (#21260)

Browse source 
Fixes #21259.
This commit is contained in:
Nick Treleaven 2025-04-18 13:29:13 +01:00 • committed by GitHub
parent bc3c423fd7
commit 011c27165e
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 49 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

8
compiler/src/dmd/expressionsem.d
View file

@ -10579,7 +10579,12 @@ private extern (C++) final class ExpressionSemanticVisitor : Visitor
{
TupleDeclaration td = isAliasThisTuple(e2x);
if (!td)
goto Lnomatch;
{
Lnomatch:
error(exp.loc, "cannot assign `%s` to expression sequence `%s`",
exp.e2.type.toChars(), exp.e1.type.toChars());
return setError();
}
assert(exp.e1.type.ty == Ttuple);
TypeTuple tt = cast(TypeTuple)exp.e1.type;
@ -10621,7 +10626,6 @@ private extern (C++) final class ExpressionSemanticVisitor : Visitor
// Do not need to overwrite this.e2
goto Ltupleassign;
}
Lnomatch:
}
/* Inside constructor, if this is the first assignment of object field,

43
compiler/test/fail_compilation/seq_assign.d Normal file
View file

@ -0,0 +1,43 @@
/*
TEST_OUTPUT:
---
fail_compilation/seq_assign.d(28): Error: cannot assign `int` to expression sequence `(int)`
fail_compilation/seq_assign.d(29): Error: cannot implicitly convert expression `s` of type `string` to `int`
fail_compilation/seq_assign.d(30): Error: cannot modify constant `2`
fail_compilation/seq_assign.d(31): Error: mismatched sequence lengths, 1 and 2
fail_compilation/seq_assign.d(35): Error: mismatched sequence lengths, 1 and 2
fail_compilation/seq_assign.d(36): Error: cannot implicitly convert expression `__t_field_0` of type `string` to `int`
fail_compilation/seq_assign.d(40): Error: cannot assign `IntString` to expression sequence `(string, int)`
fail_compilation/seq_assign.d(42): Error: cannot implicitly convert expression `AliasSeq!(b, c)` of type `(int, int)` to `IntString`
---
*/
alias Seq(A...) = A;
struct IntString
{
Seq!(int, string) expand;
alias this = expand;
}
void main()
{
int b, c;
string s;
Seq!(b,) = 1; // RHS not seq
Seq!(b,) = Seq!(s,); // b type error
Seq!(2,) = Seq!(1,); // not lvalue
Seq!(b,) = Seq!(1, 2); // too many
auto t = Seq!("two", 3);
Seq!(s, b) = t; // OK
Seq!(b,) = t; // too many
Seq!(b, c) = t; // b type error
IntString t2;
Seq!(b, s) = t2; // OK
t = t2; // type mismatch
t2 = Seq!(b, s); // OK
t2 = Seq!(b, c); // c wrong type
}