mirrors/D-Scanner
1
0
Fork 0
mirror of https://github.com/dlang-community/D-Scanner.git synced 2025-05-14 14:56:03 +03:00
Code Issues Projects Releases Packages Wiki Activity Actions

Update dsymbol and dparse

Browse source
This commit is contained in:
Hackerpilot 2016-10-12 19:28:51 -07:00
parent 762dee0482
commit 896d7da6f4
12 changed files with 42 additions and 34 deletions
Download patch file Download diff file Expand all files Collapse all files

14
src/analysis/enumarrayliteral.d
View file

@ -8,7 +8,7 @@ module analysis.enumarrayliteral;
import dparse.ast;
import dparse.lexer;
import analysis.base;
import std.algorithm : canFind;
import std.algorithm : canFind, map;
import dsymbol.scope_ : Scope;
void doNothing(string, size_t, size_t, string, bool)
@ -35,19 +35,19 @@ class EnumArrayLiteralCheck : BaseAnalyzer
{
if (autoDec.storageClasses.canFind!(a => a.token == tok!"enum"))
{
foreach (i, initializer; autoDec.initializers)
foreach (part; autoDec.parts)
{
if (initializer is null)
if (part.initializer is null)
continue;
if (initializer.nonVoidInitializer is null)
if (part.initializer.nonVoidInitializer is null)
continue;
if (initializer.nonVoidInitializer.arrayInitializer is null)
if (part.initializer.nonVoidInitializer.arrayInitializer is null)
continue;
addErrorMessage(autoDec.identifiers[i].line, autoDec.identifiers[i].column,
addErrorMessage(part.identifier.line, part.identifier.column,
"dscanner.performance.enum_array_literal",
"This enum may lead to unnecessary allocation at run-time."
~ " Use 'static immutable "
~ autoDec.identifiers[i].text ~ " = [ ...' instead.");
~ part.identifier.text ~ " = [ ...' instead.");
}
}
autoDec.accept(this);