mirrors/D-Scanner
1
0
Fork 0
mirror of https://github.com/dlang-community/D-Scanner.git synced 2025-04-26 05:10:03 +03:00
Code Issues Projects Releases Packages Wiki Activity Actions

more sane parentheses fix for delegates

Browse source 
not sure what I was thinking with the initial version
This commit is contained in:
WebFreak001 2023-07-12 13:52:54 +02:00 • committed by Jan Jurzitza
parent 7601fe65f9
commit 5d67707744
1 changed files with 4 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

9
src/dscanner/analysis/lambda_return_check.d
View file

@ -49,8 +49,7 @@ final class LambdaReturnCheck : BaseAnalyzer
.concat(AutoFix.insertionAfter(fLit.tokens[0], ")")) .concat(AutoFix.insertionAfter(fLit.tokens[0], ")"))
.concat(AutoFix.replacement(arrow[0], "")); .concat(AutoFix.replacement(arrow[0], ""));
} }
autofixes ~= AutoFix.insertionBefore(*endIncl, "(", "Add parenthesis (return delegate)") autofixes ~= AutoFix.insertionBefore(*endIncl, "() ", "Add parenthesis (return delegate)");
.concat(AutoFix.insertionAfter(fe.specifiedFunctionBody.tokens[$ - 1], ")"));
addErrorMessage(tokens, KEY, "This lambda returns a lambda. Add parenthesis to clarify.", addErrorMessage(tokens, KEY, "This lambda returns a lambda. Add parenthesis to clarify.",
autofixes); autofixes);
} }
@ -101,11 +100,11 @@ unittest
{ {
int[] b; int[] b;
auto a = b.map!((a) { return a * a + 2; }).array(); // fix:0 auto a = b.map!((a) { return a * a + 2; }).array(); // fix:0
auto a = b.map!(a => ({ return a * a + 2; })).array(); // fix:1 auto a = b.map!(a => () { return a * a + 2; }).array(); // fix:1
pragma(msg, typeof((a) { return a; })); // fix:0 pragma(msg, typeof((a) { return a; })); // fix:0
pragma(msg, typeof(a => ({ return a; }))); // fix:1 pragma(msg, typeof(a => () { return a; })); // fix:1
pragma(msg, typeof((a) { return a; })); // fix:0 pragma(msg, typeof((a) { return a; })); // fix:0
pragma(msg, typeof((a) => ({ return a; }))); // fix:1 pragma(msg, typeof((a) => () { return a; })); // fix:1
} }
}c, sac); }c, sac);