Fix #140

libdparse

@@ -1 +1 @@
-Subproject commit 256b979f3b53c3367b6556c5b68e9cc76ceaf391
+Subproject commit ccb3d98996f89cfb35799aee6358e640f6f71f67

src/dfmt/formatter.d

@@ -475,8 +475,19 @@ private:
             linebreakHints = [];
             while (indents.topIs(tok!"enum"))
                 indents.pop();
+            if (config.dfmt_brace_style == BraceStyle.allman)
+            {
+                if (!currentIs(tok!"{"))
                     newline();
             }
+            else
+            {
+                if (currentIs(tok!"{"))
+                    indents.popTempIndents();
+                indentLevel = indents.indentSize;
+                newline();
+            }
+        }
     }
 
     void formatLeftBrace()
@@ -517,31 +528,29 @@ private:
             }
         }
         else
-        {
-            if (!justAddedExtraNewline && !peekBackIsOneOf(false, tok!"{",
-                    tok!"}", tok!";", tok!";"))
-            {
-                if (config.dfmt_brace_style != BraceStyle.allman)
-                {
-                    if (!astInformation.structInitStartLocations.canFindIndex(tokens[index].index)
-                            && !astInformation.funLitStartLocations.canFindIndex(
-                            tokens[index].index))
         {
             indents.popWrapIndents();
-                        indents.push(tok!"{");
-                        if (index == 1 || peekBackIsOneOf(true, tok!":", tok!"{",
-                                tok!"}", tok!")", tok!";"))
+            if (indents.length && isTempIndent(indents.top))
+                indentLevel = indents.indentSize - 1;
+            else
+                indentLevel = indents.indentSize;
+
+            if (!peekBackIsSlashSlash())
             {
+                if (config.dfmt_brace_style == BraceStyle.allman || peekBackIsOneOf(true, tok!"{", tok!"}"))
+                    newline();
+                else if (!peekBackIsOneOf(true, tok!"{", tok!"}", tok!";"))
+                    write(" ");
+                writeToken();
+            }
+            else
+            {
+                writeToken();
+                indents.popTempIndents();
                 indentLevel = indents.indentSize - 1;
             }
-                    }
-                    write(" ");
-                }
-                else if (index > 0 && (!peekBackIs(tok!"comment")
-                        || tokens[index - 1].text[0 .. 2] != "//"))
-                    newline();
-            }
-            writeToken();
+            indents.push(tok!"{");
+            if (!currentIs(tok!"{"))
                 newline();
             linebreakHints = [];
         }
@@ -584,9 +593,9 @@ private:
                 currentLineLength = 0;
                 justAddedExtraNewline = true;
             }
-            if (config.dfmt_brace_style == BraceStyle.otbs && currentIs(tok!"else"))
+            if (config.dfmt_brace_style != BraceStyle.allman && currentIs(tok!"else"))
                 write(" ");
-            if (!peekIs(tok!",") && !peekIs(tok!")") && !peekIs(tok!";"))
+            if (!peekIs(tok!",") && !peekIs(tok!")") && !peekIs(tok!";") && !peekIs(tok!"{"))
             {
                 index++;
                 newline();
@@ -967,7 +976,7 @@ private:
         if (currentIs(tok!"comment") && index > 0 && current.line == tokenEndLine(tokens[index - 1]))
             return;
 
-        immutable bool hasCurrent = index + 1 < tokens.length;
+        immutable bool hasCurrent = index < tokens.length;
 
         if (niBraceDepth > 0 && !peekBackIsSlashSlash() && hasCurrent
                 && tokens[index].type == tok!"}" && !assumeSorted(
@@ -1031,16 +1040,13 @@ private:
                 if (l != -1)
                     indentLevel = l;
             }
-            else if (currentIs(tok!"{")
-                    && !astInformation.structInitStartLocations.canFindIndex(tokens[index].index)
-                    && !astInformation.funLitStartLocations.canFindIndex(tokens[index].index))
+            else if (currentIs(tok!"{"))
             {
                 indents.popWrapIndents();
-                indents.push(tok!"{");
-                if (index == 1 || peekBackIsOneOf(true, tok!":", tok!"{",
-                        tok!"}", tok!")", tok!";", tok!"identifier") || peekBackIsKeyword())
+                if (peekBackIsSlashSlash())
                 {
-                    indentLevel = indents.indentSize - 1;
+                    indents.popTempIndents();
+                    indentLevel = indents.indentSize;
                 }
             }
             else if (currentIs(tok!"}"))
@@ -1051,8 +1057,7 @@ private:
                     indentLevel = indents.indentToMostRecent(tok!"{");
                     indents.pop();
                 }
-                while (indents.length && isTempIndent(indents.top)
-                        && ((indents.top != tok!"if"
+                while (indents.topIsTemp() && ((indents.top != tok!"if"
                         && indents.top != tok!"version") || !peekIs(tok!"else")))
                 {
                     indents.pop();
@@ -1075,8 +1080,7 @@ private:
             }
             else
             {
-                while (indents.length && (peekBackIsOneOf(true, tok!"}",
-                        tok!";") && indents.top != tok!";") && isTempIndent(indents.top()))
+                while (indents.topIsTemp() && (peekBackIsOneOf(true, tok!"}", tok!";") && indents.top != tok!";"))
                 {
                     indents.pop();
                 }

src/dfmt/indentation.d

@@ -75,6 +75,16 @@ struct IndentStack
         return index > 0 && arr[index] == type;
     }
 
+    bool topIsTemp()
+    {
+        return index > 0 && index < arr.length && isTempIndent(arr[index]);
+    }
+
+    bool topIsWrap()
+    {
+        return index > 0 && index < arr.length && isWrapIndent(arr[index]);
+    }
+
     bool topIsOneOf(IdType[] types...) const pure nothrow @safe @nogc
     {
         if (index <= 0)

tests/allman/issue0023.d.ref

@@ -32,4 +32,5 @@ string generateFixedLengthCases()
         "=>", ">", ">=", ">>", ">>=", ">>>", ">>>=", "?", "@", "[", "]", "^",
         "^=", "^^", "^^=", "{", "|", "|=", "||", "}", "~", "~="
     ];
+
 }

tests/allman/issue0054.d.ref

@@ -24,4 +24,5 @@ struct ClassFlags
     alias isAbstract = Enum.isAbstract;
     alias isCPPclass = Enum.isCPPclass;
     alias hasDtor = Enum.hasDtor;
+
 }

tests/allman/issue0140.d.ref

@@ -0,0 +1,6 @@
+class C
+{
+
+    int foo;
+
+}

tests/issue0140.d

@@ -0,0 +1,6 @@
+class C
+{
+
+	int foo;
+
+}

tests/otbs/issue0023.d.ref

@@ -31,4 +31,5 @@ string generateFixedLengthCases() {
         "=>", ">", ">=", ">>", ">>=", ">>>", ">>>=", "?", "@", "[", "]", "^",
         "^=", "^^", "^^=", "{", "|", "|=", "||", "}", "~", "~="
     ];
+
 }

tests/otbs/issue0027.d.ref

@@ -26,19 +26,19 @@ unittest {
         fd.storage_class2 |= stc;
     }
 
-        }
+}
 
-        SignExtendedNumber opMul(const SignExtendedNumber a) const {
+SignExtendedNumber opMul(const SignExtendedNumber a) const {
     /* Special handling for zeros:
     */
 
     //  like 0x10 * 0x10 == 0x100 == 0.
-        }
+}
 
-        // Because int64_t and friends may be any integral type of the
-        // correct size, we have to explicitly ask for the correct
-        // integer type to get the correct mangling with ddmd
+// Because int64_t and friends may be any integral type of the
+// correct size, we have to explicitly ask for the correct
+// integer type to get the correct mangling with ddmd
 
-        // Be careful not to care about sign when using dinteger_t
-        // use this instead of integer_t to
+// Be careful not to care about sign when using dinteger_t
+// use this instead of integer_t to
 // avoid conflicts with system #include's

tests/otbs/issue0054.d.ref

@@ -22,4 +22,5 @@ struct ClassFlags {
     alias isAbstract = Enum.isAbstract;
     alias isCPPclass = Enum.isCPPclass;
     alias hasDtor = Enum.hasDtor;
+
 }

tests/otbs/issue0140.d.ref

@@ -0,0 +1,5 @@
+class C {
+
+    int foo;
+
+}