From cc7f54e894ac5a6c3caae84454d8116fcd2d4aad Mon Sep 17 00:00:00 2001
From: Basile Burg <basile.b@gmx.com>
Date: Fri, 15 Mar 2019 12:23:10 +0100
Subject: [PATCH] fix #452 - Freeze at startup due to too long dastworx command
 line

---
 src/u_dastworx.pas | 46 +++++++++++++++++++++++++++++++++++++++++++---
 1 file changed, 43 insertions(+), 3 deletions(-)

diff --git a/src/u_dastworx.pas b/src/u_dastworx.pas
index 81510d41..434dad13 100644
--- a/src/u_dastworx.pas
+++ b/src/u_dastworx.pas
@@ -4,7 +4,8 @@ unit u_dastworx;
 interface
 
 uses
-  Classes, SysUtils, process, jsonscanner, fpjson, jsonparser, u_common;
+  Classes, SysUtils, process, jsonscanner, fpjson, jsonparser,
+  u_common, u_dialogs;
 
 (**
  * Gets the module name and the imports of the source code located in
@@ -18,7 +19,7 @@ procedure getModuleImports(source, imports: TStrings);
  * source. Each line in "import" that contains double quoted text indicates
  * that a new group of import starts.
  *)
-procedure getModulesImports(const files: string; results: TStrings);
+procedure getModulesImports(files: string; results: TStrings);
 
 procedure getHalsteadMetrics(source: TStrings; out jsn: TJSONObject);
 
@@ -64,14 +65,49 @@ begin
   end;
 end;
 
-procedure getModulesImports(const files: string; results: TStrings);
+procedure getModulesImports(files: string; results: TStrings);
 var
   str: string;
   prc: TProcess;
+  {$ifdef WINDOWS}
+  cdr: string = '';
+  itm: string;
+  spl: TStringList;
+  i: integer;
+  {$endif}
 begin
   str := getToolName;
   if str.isEmpty then
     exit;
+  {$ifdef WINDOWS}
+  if files.length > 32760{not 8 : "-f -i" length} then
+  begin
+    spl := TStringList.Create;
+    try
+      spl.LineBreak := ';';
+      spl.AddText(files);
+      cdr := commonFolder(spl);
+      if not cdr.dirExists then
+      begin
+        dlgOkError('Impossible to find the common directory in the list to analyze the imports:  ' + shortenPath(files, 200));
+        exit;
+      end;
+      for i:= 0 to spl.count-1 do
+      begin
+        itm := spl.strings[i];
+        spl.strings[i] := itm[cdr.length + 2 .. itm.length];
+      end;
+      files := spl.strictText;
+      if files.length > 32760 then
+      begin
+        dlgOkError('Too much files in the list to analyze the imports:  ' + shortenPath(files, 200));
+        exit;
+      end;
+    finally
+      spl.Free;
+    end;
+  end;
+  {$endif}
   prc := TProcess.Create(nil);
   try
     prc.Executable := str;
@@ -79,6 +115,10 @@ begin
     prc.Parameters.Add('-i');
     prc.Options := [poUsePipes {$IFDEF WINDOWS}, poNewConsole{$ENDIF}];
     prc.ShowWindow := swoHIDE;
+    {$ifdef WINDOWS}
+    if cdr.isNotEmpty then
+      prc.CurrentDirectory := cdr;
+    {$endif}
     prc.Execute;
     prc.CloseInput;
     processOutputToStrings(prc, results);