From bac1a99efcc9de2ceeb59655e624ecc78e1491de Mon Sep 17 00:00:00 2001 From: Basile Burg Date: Thu, 19 Feb 2015 11:15:17 +0100 Subject: [PATCH 1/4] doc comments --- src/ce_interfaces.pas | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/ce_interfaces.pas b/src/ce_interfaces.pas index 1b4e6586..104a11f5 100644 --- a/src/ce_interfaces.pas +++ b/src/ce_interfaces.pas @@ -118,7 +118,7 @@ type (** - * An implementer can expose some customizable shortcuts + * An implementer can expose some customizable shortcuts to be edited in a dedicated widget. *) ICEEditableShortCut = interface ['ICEEditableShortCut'] @@ -141,7 +141,7 @@ type - TOptionEditorKind = (oekAbstract, oekForm); + TOptionEditorKind = (oekGeneric, oekForm); TOptionEditorEvent = (oeeCancel, oeeAccept, oeeChange); (** * An implementer can expose some options to be edited in a dedicated widget. @@ -249,7 +249,7 @@ type { - Service assignators: + Service getters: Lazily get the interface of a service when needed or for a punctual usage. The first overload assign the variable only when not yet set, the second is @@ -402,7 +402,7 @@ begin end; {$ENDREGION} -{$REGION ICESingleService assignators ------------------------------------------} +{$REGION ICESingleService getters ----------------------------------------------} function getMessageDisplay(var obj: ICEMessagesDisplay): ICEMessagesDisplay; begin if obj = nil then From 566bd6bbd314fe41cabab842e5e7e38df8d4b14b Mon Sep 17 00:00:00 2001 From: Basile Burg Date: Thu, 19 Feb 2015 11:15:40 +0100 Subject: [PATCH 2/4] renamed enum member --- src/ce_editoroptions.pas | 2 +- src/ce_messages.pas | 2 +- src/ce_optionseditor.pas | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/ce_editoroptions.pas b/src/ce_editoroptions.pas index 1583bb93..e8747a52 100644 --- a/src/ce_editoroptions.pas +++ b/src/ce_editoroptions.pas @@ -221,7 +221,7 @@ end; function TCEEditorOptions.optionedWantEditorKind: TOptionEditorKind; begin - exit(oekAbstract); + exit(oekGeneric); end; function TCEEditorOptions.optionedWantContainer: TPersistent; diff --git a/src/ce_messages.pas b/src/ce_messages.pas index c4a8197a..b6d7e59d 100644 --- a/src/ce_messages.pas +++ b/src/ce_messages.pas @@ -235,7 +235,7 @@ end; function TCEMessagesWidget.optionedWantEditorKind: TOptionEditorKind; begin - exit(oekAbstract); + exit(oekGeneric); end; function TCEMessagesWidget.optionedWantContainer: TPersistent; diff --git a/src/ce_optionseditor.pas b/src/ce_optionseditor.pas index fb6cb26b..16fa6dfd 100644 --- a/src/ce_optionseditor.pas +++ b/src/ce_optionseditor.pas @@ -123,7 +123,7 @@ begin TForm(dt^.container).Align := alClient; TForm(dt^.container).BorderStyle:= bsNone; end; - oekAbstract: + oekGeneric: begin inspector.Parent := pnlEd; inspector.Align := alClient; From 329af7d3fdb4cbf19ef3656aac972d49f7fee47d Mon Sep 17 00:00:00 2001 From: Basile Burg Date: Thu, 19 Feb 2015 11:15:51 +0100 Subject: [PATCH 3/4] updated readme --- README.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/README.md b/README.md index 1ba40f64..6fed9482 100644 --- a/README.md +++ b/README.md @@ -24,6 +24,8 @@ Current features Missing features before the first beta -------------------------------------- - Options editor. +- Shortcuts editor. +- a few context menus and toolbars. Project information ------------------- From a6e556d183babfa2d11c0854adac6cf145fcd4a7 Mon Sep 17 00:00:00 2001 From: Basile Burg Date: Thu, 19 Feb 2015 11:16:45 +0100 Subject: [PATCH 4/4] fix, hint not re-shown until scroll/click/move elsewhere --- src/ce_main.pas | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/ce_main.pas b/src/ce_main.pas index 288a7e84..5889ea45 100644 --- a/src/ce_main.pas +++ b/src/ce_main.pas @@ -858,6 +858,8 @@ begin TCEEditorHintWindow.FontSize := fDoc.Font.Size; HintInfo.HintWindowClass := TCEEditorHintWindow; HintInfo.HideTimeout := 120000; + HintInfo.CursorRect.Left := fDoc.CaretXPix; + HintInfo.CursorRect.Top := fDoc.CaretYPix; // note: non-default color allows non-themed draw() which allows custom font-size to be handled. HintInfo.HintColor := clInfoBk + $01010100; //