From 7c88b5a8e8180fc4a5f50aa2fd9367e626701887 Mon Sep 17 00:00:00 2001
From: Basile Burg <basile.b@gmx.com>
Date: Fri, 29 May 2020 09:38:49 +0200
Subject: [PATCH] fix, terminal scrollbar didn't handle the min pos

---
 CHANGELOG.md   | 1 +
 src/u_term.lfm | 1 -
 src/u_term.pas | 5 +++--
 3 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 08fbd959..4793f633 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -11,6 +11,7 @@
 - Messages: force auto scrolling to bottom once and if the messages context is modified.
 - Runnables: ldc2 was not translated to ldmd when the "global compiler" was set to compile the runnables. (#43)
 - Terminal: after launching dexed, the current directory was not constrained even when the settings to follow the current project or document path were activated. (#5)
+- Terminal: problem with the min position of the scrollbar. Visible for example when a program output more lines then the *scrollbackLines* setting.
 - Windows: fixed broken compilation that was caused by libdexed-d.
 
 # v3.9.3
diff --git a/src/u_term.lfm b/src/u_term.lfm
index 39e0a66e..0e4de3b6 100644
--- a/src/u_term.lfm
+++ b/src/u_term.lfm
@@ -39,7 +39,6 @@ inherited TermWidget: TTermWidget
       end
     end
     inherited toolbar: TDexedToolBar
-      Height = 30
       Width = 666
     end
   end
diff --git a/src/u_term.pas b/src/u_term.pas
index f86a55d8..5ee835c2 100644
--- a/src/u_term.pas
+++ b/src/u_term.pas
@@ -50,7 +50,7 @@ type
     property followEditors: boolean read fFollowEditors write fFollowEditors;
     property followProjects: boolean read fFollowProjects write fFollowProjects;
     property followExplorer: boolean read fFollowExplorer write fFollowExplorer;
-    property scrollbackLines: longword read fScrollbackLines write fScrollbackLines default 512;
+    property scrollbackLines: longword read fScrollbackLines write fScrollbackLines default 10000;
     property shortcuts: TTerminalShortcuts read fShortcuts write fShortcuts;
   end;
 
@@ -146,7 +146,7 @@ begin
   fSelectedColor:= clBlack;
   fFont.Name:= 'Monospace';
   fFont.Size:= 12;
-  fScrollbackLines:=512;
+  fScrollbackLines:=10000;
   fShortcuts := TTerminalShortcuts.create;
 end;
 
@@ -342,6 +342,7 @@ begin
   if fDisableScrollBarSync or not visible or fTerm.isNil then
     exit;
   i                   := fTerm.getVScrollInfo();
+  ScrollBar1.Min      := i.min;
   ScrollBar1.Max      := i.max;
   ScrollBar1.Position := i.value;
   ScrollBar1.PageSize := i.pageSize;