mirror of https://github.com/adamdruppe/arsd.git
e18fb69779
The debugger tells me the Invoke method is accessing an invalid, but non-null pointer. This appears to be a use-after-free delegate context pointer. This is not easy to reproduce - even with the browser, I'd have to open and close tons of windows and trigger specific callbacks to get the behavior. (I found the best one to get it was the status text changed event out of WebView2, probably because it uses a member variable without any explicit local.) I suspect it has to do with the delegate trying to capture both `this` and other local variables at the same time. I couldn't confirm this, but the theory is that normally, when a delegate captures a local variable, the compiler places it in an allocated heap block instead of on the stack, but perhaps `this` gets different treatment and it is wiped out or the block is GC'd or something. (The AddRef does GC.addRoot to the containing class that had the delegate member, so that should have prevented it from disappearing, but it is possible I did it wrong.) Nevertheless, I recall having trouble with this in the past as well, and decided perhaps the best thing to do is to just take control of which context, exactly, is passed and retained. Hence the conversion to `function` so I can hold on to it better. This makes things harder to use - especially since IFTI wouldn't pick up the usage correctly - but meh, I'm mostly just passing the class handles down so not that bad. Not 100% sure this actually even fixed the crash; it hasn't happened again since using it, but that's no guarantee given how difficult it is to reproduce. |
||
|---|---|---|
| .. | ||
| color_dialog.d | ||
| datetime_picker.d | ||
| nanovega.d | ||
| package.d | ||
| terminal_emulator_widget.d | ||
| webview.d | ||