forks
/
arsd
mirror of https://github.com/adamdruppe/arsd.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
2,597 Commits 2 Branches 172 Tags 14 MiB
Commit Graph

25 Commits

Author SHA1 Message Date
Adam D. Ruppe 63b404ca24 doc fix 2024-11-23 15:22:44 -05:00
Adam D. Ruppe 71a211bc5e open new window in current instance of browser support 2024-07-25 18:52:17 -04:00
Adam D. Ruppe 74fe3159d7 update cef again 2024-07-25 18:52:17 -04:00
Adam D. Ruppe 01c7b280ad surrogate pairs 2024-03-21 11:23:13 -04:00
Adam D. Ruppe 7641aeb2dc dangling else lol 2023-12-30 08:14:26 -05:00
Adam D. Ruppe e18fb69779 Try to resolve random crash on Windows 
The debugger tells me the Invoke method is accessing an invalid, but
non-null pointer. This appears to be a use-after-free delegate context
pointer. This is not easy to reproduce - even with the browser, I'd have
to open and close tons of windows and trigger specific callbacks to get
the behavior. (I found the best one to get it was the status text
changed event out of WebView2, probably because it uses a member
variable without any explicit local.)

I suspect it has to do with the delegate trying to capture both `this`
and other local variables at the same time. I couldn't confirm this, but
the theory is that normally, when a delegate captures a local variable,
the compiler places it in an allocated heap block instead of on the
stack, but perhaps `this` gets different treatment and it is wiped out
or the block is GC'd or something. (The AddRef does GC.addRoot to the
containing class that had the delegate member, so that should have
prevented it from disappearing, but it is possible I did it wrong.)

Nevertheless, I recall having trouble with this in the past as well,
and decided perhaps the best thing to do is to just take control of
which context, exactly, is passed and retained. Hence the conversion to
`function` so I can hold on to it better. This makes things harder to
use - especially since IFTI wouldn't pick up the usage correctly - but
meh, I'm mostly just passing the class handles down so not that bad.

Not 100% sure this actually even fixed the crash; it hasn't happened
again since using it, but that's no guarantee given how difficult it is
to reproduce.
 2023-12-24 19:46:46 -05:00
Adam D. Ruppe d31ca0b91f stuff for my browser 2023-12-19 21:14:20 -05:00
Adam D. Ruppe 95ea3af2b1 update bindings to MSFT webview2 2023-12-16 13:17:59 -05:00
Adam D. Ruppe 1e04f8e683 how the heck did i put all these in here and not have it fail building before 2023-12-15 20:24:35 -05:00
Adam D. Ruppe 58133b5fd3 update to newer cef 2023-11-22 18:59:29 -05:00
John Colvin 251cb73f71 remove trailing whitespace 2023-03-02 14:00:12 +00:00
Adam D. Ruppe ba77439507 update cef to latest again 2022-11-15 09:53:29 -05:00
Adam D. Ruppe 7b2e819357 stuff 2022-06-13 20:38:21 -04:00
Adam D. Ruppe ce2f7d5f94 more browser stuff, still not stable! 2022-04-05 19:16:15 -04:00
Adam D. Ruppe 12bb6d7f4d add more stuff to dub 2021-12-09 22:23:41 -05:00
Adam D. Ruppe 7e4938690a some new web conveniences (experimental) and some bug fixes 2021-11-18 22:23:18 -05:00
Adam D. Ruppe d177023e44 more work in progress 2021-11-10 09:47:03 -05:00
Adam D. Ruppe 55512a8d42 getting cef implementation started 2021-11-05 10:45:52 -04:00
Adam D. Ruppe b861cf5f46 catching up 2021-02-22 23:27:39 -05:00
Adam D. Ruppe a8ec499f2b random fixes 2021-02-01 21:35:56 -05:00
Adam D. Ruppe edc4b393aa edge stuff 2021-01-22 11:12:48 -05:00
Adam D. Ruppe 868323bac0 omg i forgot stuff 2021-01-19 23:03:19 -05:00
Adam D. Ruppe b490ed1ab5 updates 2019-12-16 16:31:07 -05:00
Adam D. Ruppe b5d037fa56 release prep 2019-12-06 15:48:20 -05:00
Adam D. Ruppe 677d4a3da9 initial add 2019-11-30 23:20:22 -05:00