forks
/
arsd
mirror of https://github.com/adamdruppe/arsd.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Allow "…CalcDims" functions to be less consistent 

Not all consistency is good.
This commit is contained in:
Elias Batek 2024-10-13 19:04:25 +02:00
parent a23b056822
commit c4485e3f88
1 changed files with 9 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
pixmappaint.d
View File

@ -303,8 +303,8 @@
Such functions are identified by a `-CalcDims` suffix; Such functions are identified by a `-CalcDims` suffix;
e.g. [flipHorizontallyCalcDims] or [cropCalcDims]. e.g. [flipHorizontallyCalcDims] or [cropCalcDims].
They receive the same parameters as their corresponding “source to new They usually take the same parameters as their corresponding
target” function. For consistency reasons this also applies in cases where “source to new target” function. This does not apply in cases where
certain parameters are irrelevant for the computation of the target size. certain parameters are irrelevant for the computation of the target size.
+/ +/
module arsd.pixmappaint; module arsd.pixmappaint;
@ -2121,14 +2121,14 @@ private void decreaseOpacityInto(const Pixmap source, Pixmap target, ubyte opaci
Use [decreaseOpacityF] with decimal opacity values in percent (%). Use [decreaseOpacityF] with decimal opacity values in percent (%).
+/ +/
Pixmap decreaseOpacity(const Pixmap source, Pixmap target, ubyte opacityPercentage) @nogc { Pixmap decreaseOpacity(const Pixmap source, Pixmap target, ubyte opacityPercentage) @nogc {
target.adjustTo(source.decreaseOpacityCalcDims(opacityPercentage)); target.adjustTo(source.decreaseOpacityCalcDims());
source.decreaseOpacityInto(target, opacityPercentage); source.decreaseOpacityInto(target, opacityPercentage);
return target; return target;
} }
/// ditto /// ditto
Pixmap decreaseOpacityNew(const Pixmap source, ubyte opacityPercentage) { Pixmap decreaseOpacityNew(const Pixmap source, ubyte opacityPercentage) {
auto target = Pixmap.makeNew(source.decreaseOpacityCalcDims(opacityPercentage)); auto target = Pixmap.makeNew(source.decreaseOpacityCalcDims());
source.decreaseOpacityInto(target, opacityPercentage); source.decreaseOpacityInto(target, opacityPercentage);
return target; return target;
} }
@ -2141,7 +2141,7 @@ void decreaseOpacityInPlace(Pixmap source, ubyte opacityPercentage) @nogc {
} }
/// ditto /// ditto
PixmapBlueprint decreaseOpacityCalcDims(const Pixmap source, ubyte opacity) @nogc { PixmapBlueprint decreaseOpacityCalcDims(const Pixmap source) @nogc {
return PixmapBlueprint.fromPixmap(source); return PixmapBlueprint.fromPixmap(source);
} }
@ -2164,12 +2164,12 @@ Pixmap decreaseOpacityFNew(const Pixmap source, float opacityPercentage) {
} }
/// ditto /// ditto
void decreaseOpacityFInPlace(Pixmap source, const float opacityPercentage) @nogc { void decreaseOpacityFInPlace(Pixmap source, float opacityPercentage) @nogc {
return source.decreaseOpacityInPlace(percentageDecimalToUInt8(opacityPercentage)); return source.decreaseOpacityInPlace(percentageDecimalToUInt8(opacityPercentage));
} }
/// ditto /// ditto
PixmapBlueprint decreaseOpacityF(Pixmap source, const float opacityPercentage) @nogc { PixmapBlueprint decreaseOpacityF(Pixmap source) @nogc {
return PixmapBlueprint.fromPixmap(source); return PixmapBlueprint.fromPixmap(source);
} }
@ -2253,7 +2253,7 @@ private alias cropInto = cropTo;
The target Pixmap must be big enough in length to hold the cropped image. The target Pixmap must be big enough in length to hold the cropped image.
+/ +/
Pixmap crop(const Pixmap source, Pixmap target, Size cropToSize, Point offset = Point(0, 0)) @nogc { Pixmap crop(const Pixmap source, Pixmap target, Size cropToSize, Point offset = Point(0, 0)) @nogc {
target.adjustTo(source.cropCalcDims(cropToSize, offset)); target.adjustTo(cropCalcDims(cropToSize));
cropInto(source, target, offset); cropInto(source, target, offset);
return target; return target;
} }
@ -2277,7 +2277,7 @@ Pixmap cropInPlace(Pixmap source, Size cropToSize, Point offset = Point(0, 0)) @
} }
/// ditto /// ditto
PixmapBlueprint cropCalcDims(const Pixmap source, Size cropToSize, Point offset = Point(0, 0)) @nogc { PixmapBlueprint cropCalcDims(Size cropToSize) @nogc {
return PixmapBlueprint.fromSize(cropToSize); return PixmapBlueprint.fromSize(cropToSize);
} }