From 9c5a341bce2da48453e49b9452ca098bb8dd472d Mon Sep 17 00:00:00 2001
From: Elias Batek <desisma@heidel.beer>
Date: Sun, 12 Jan 2025 01:57:24 +0100
Subject: [PATCH] Move `ScalingFilter` to PixmapPaint

---
 pixmappaint.d     | 44 ++++++++++++++++++++++++++++----------------
 pixmappresenter.d |  6 ------
 2 files changed, 28 insertions(+), 22 deletions(-)

diff --git a/pixmappaint.d b/pixmappaint.d
index 90c2238..ff52370 100644
--- a/pixmappaint.d
+++ b/pixmappaint.d
@@ -2773,16 +2773,28 @@ PixmapBlueprint flipVerticallyCalcDims(const Pixmap source) @nogc {
 }
 
 ///
-enum ScalingMethod {
-	///
+enum ScalingFilter {
+	/++
+		Nearest neighbour interpolation
+
+		Also known $(B proximal interpolation)
+		and $(B point sampling).
+
+		$(TIP
+			Visual impression: “blocky”, “pixel’ish”
+		)
+	 +/
 	nearest,
 
-	///
-	linear, // TODO: Decide whether to replace this
-	//       by moving over `ScalingFilter` from `arsd.pixmappresenter`.
-}
+	/++
+		(Bi-)linear interpolation
 
-private alias Scale = ScalingMethod;
+		$(TIP
+			Visual impression: “smooth”, “blurry”
+		)
+	 +/
+	linear,
+}
 
 private enum ScalingDirection {
 	none,
@@ -2800,7 +2812,7 @@ private static ScalingDirection scalingDirectionFromDelta(const int delta) @nogc
 	}
 }
 
-private void scaleToImpl(Scale method)(const Pixmap source, Pixmap target) @nogc {
+private void scaleToImpl(ScalingFilter method)(const Pixmap source, Pixmap target) @nogc {
 
 	enum none = ScalingDirection.none;
 	enum up = ScalingDirection.up;
@@ -2831,7 +2843,7 @@ private void scaleToImpl(Scale method)(const Pixmap source, Pixmap target) @nogc
 	}
 
 	// Nearest Neighbour
-	static if (method == Scale.nearest) {
+	static if (method == ScalingFilter.nearest) {
 		auto dst = PixmapScannerRW(target);
 
 		size_t y = 0;
@@ -2844,22 +2856,22 @@ private void scaleToImpl(Scale method)(const Pixmap source, Pixmap target) @nogc
 			}
 			++y;
 		}
-	} else static if (method == Scale.linear) {
+	} else static if (method == ScalingFilter.linear) {
 		static assert(false, "Not implemented.");
 	} else {
 		static assert(false, "Scaling method not implemented yet.");
 	}
 }
 
-void scaleTo(const Pixmap source, Pixmap target, ScalingMethod method) @nogc {
+void scaleTo(const Pixmap source, Pixmap target, ScalingFilter method) @nogc {
 	import std.meta : NoDuplicates;
 	import std.traits : EnumMembers;
 
 	// dfmt off
 	final switch (method) {
-		static foreach (scalingMethod; NoDuplicates!(EnumMembers!ScalingMethod))
-			case scalingMethod: {
-				scaleToImpl!scalingMethod(source, target);
+		static foreach (scalingFilter; NoDuplicates!(EnumMembers!ScalingFilter))
+			case scalingFilter: {
+				scaleToImpl!scalingFilter(source, target);
 				return;
 			}
 	}
@@ -2878,14 +2890,14 @@ private alias scaleInto = scaleTo;
 	╚═══╝   ╚═╝
 	```
  +/
-Pixmap scale(const Pixmap source, Pixmap target, Size scaleToSize, ScalingMethod method) @nogc {
+Pixmap scale(const Pixmap source, Pixmap target, Size scaleToSize, ScalingFilter method) @nogc {
 	target.adjustTo(scaleCalcDims(scaleToSize));
 	source.scaleInto(target, method);
 	return target;
 }
 
 /// ditto
-Pixmap scaleNew(const Pixmap source, Size scaleToSize, ScalingMethod method) {
+Pixmap scaleNew(const Pixmap source, Size scaleToSize, ScalingFilter method) {
 	auto target = Pixmap.makeNew(scaleToSize);
 	source.scaleInto(target, method);
 	return target;
diff --git a/pixmappresenter.d b/pixmappresenter.d
index 858d65b..1b12910 100644
--- a/pixmappresenter.d
+++ b/pixmappresenter.d
@@ -372,12 +372,6 @@ enum Scaling {
 	cssCover = cover, /// equivalent CSS: `object-fit: cover;`
 }
 
-///
-enum ScalingFilter {
-	nearest, /// nearest neighbor → blocky/pixel’ish
-	linear, /// (bi-)linear interpolation → smooth/blurry
-}
-
 ///
 struct PresenterConfig {
 	Window window; ///