forks
/
arsd
mirror of https://github.com/adamdruppe/arsd.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

avoid some unneeded allocations

This commit is contained in:
Adam D. Ruppe 2013-06-02 21:54:32 -04:00
parent a78768c7d7
commit 848566eaf7
1 changed files with 12 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
cgi.d
View File

@ -1603,7 +1603,15 @@ class Cgi {
if(!autoBuffer || isAll) { if(!autoBuffer || isAll) {
if(rawDataOutput !is null) if(rawDataOutput !is null)
if(nph && responseChunked) { if(nph && responseChunked) {
rawDataOutput(makeChunk(cast(const(ubyte)[]) t)); //rawDataOutput(makeChunk(cast(const(ubyte)[]) t));
// we're making the chunk here instead of in a function
// to avoid unneeded gc pressure
rawDataOutput(cast(const(ubyte)[]) toHex(t.length));
rawDataOutput(cast(const(ubyte)[]) "\r\n");
rawDataOutput(cast(const(ubyte)[]) t);
rawDataOutput(cast(const(ubyte)[]) "\r\n");
} else { } else {
rawDataOutput(cast(const(ubyte)[]) t); rawDataOutput(cast(const(ubyte)[]) t);
} }
@ -2087,10 +2095,11 @@ string encodeVariables(in string[][string] data) {
// http helper functions // http helper functions
// for chunked responses (which embedded http does whenever possible) // for chunked responses (which embedded http does whenever possible)
version(none) // this is moved up above to avoid making a copy of the data
const(ubyte)[] makeChunk(const(ubyte)[] data) { const(ubyte)[] makeChunk(const(ubyte)[] data) {
const(ubyte)[] ret; const(ubyte)[] ret;
ret = cast(const(ubyte)[]) toHex(cast(int) data.length); ret = cast(const(ubyte)[]) toHex(data.length);
ret ~= cast(const(ubyte)[]) "\r\n"; ret ~= cast(const(ubyte)[]) "\r\n";
ret ~= data; ret ~= data;
ret ~= cast(const(ubyte)[]) "\r\n"; ret ~= cast(const(ubyte)[]) "\r\n";
@ -2098,7 +2107,7 @@ const(ubyte)[] makeChunk(const(ubyte)[] data) {
return ret; return ret;
} }
string toHex(int num) { string toHex(long num) {
string ret; string ret;
while(num) { while(num) {
int v = num % 16; int v = num % 16;