forks
/
arsd
mirror of https://github.com/adamdruppe/arsd.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

forgot to close read fd on posix

This commit is contained in:
Adam D. Ruppe 2020-10-08 12:43:16 -04:00
parent c2c4c00ae1
commit 213fffd1e7
1 changed files with 10 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
terminal.d
View File

@ -6266,6 +6266,8 @@ version(TerminalDirectToEmulator) {
tew.terminalEmulator.sendRawInput(buffer[0 .. ret]);
tew.terminalEmulator.redraw();
}, fds[0]);
readFd = fds[0];
}
version(Windows) {
@ -6346,6 +6348,10 @@ version(TerminalDirectToEmulator) {
}
}
version(Posix) {
int readFd = -1;
}
TerminalEmulator.TerminalCell[] delegate(TerminalEmulator.TerminalCell[] i) parentFilter;
private void addScrollbackLineFromParent(TerminalEmulator.TerminalCell[] lineIn) {
@ -6507,7 +6513,10 @@ version(TerminalDirectToEmulator) {
// will get stuck indefinitely as it tries to flush its stderr
version(Windows)
CloseHandle(wi.readPipe);
// FIXME: should I close it on Linux too?
version(Posix) {
import unix = core.sys.posix.unistd;
unix.close(wi.readFd);
}
}
// try to get it to terminate slightly more forcibly too, if possible