make show/hide work better including with native widgets when you have hidden grandchildren

core.d

@@ -1557,6 +1557,56 @@ unittest {
 	assert(flagsToString!MyFlags(2) == "b");
 }
 
+private enum dchar replacementDchar = '\uFFFD';
+
+package size_t encodeUtf8(out char[4] buf, dchar c) @safe pure {
+    if (c <= 0x7F)
+    {
+        assert(isValidDchar(c));
+        buf[0] = cast(char) c;
+        return 1;
+    }
+    if (c <= 0x7FF)
+    {
+        assert(isValidDchar(c));
+        buf[0] = cast(char)(0xC0 | (c >> 6));
+        buf[1] = cast(char)(0x80 | (c & 0x3F));
+        return 2;
+    }
+    if (c <= 0xFFFF)
+    {
+        if (0xD800 <= c && c <= 0xDFFF)
+            c = replacementDchar;
+
+        assert(isValidDchar(c));
+    L3:
+        buf[0] = cast(char)(0xE0 | (c >> 12));
+        buf[1] = cast(char)(0x80 | ((c >> 6) & 0x3F));
+        buf[2] = cast(char)(0x80 | (c & 0x3F));
+        return 3;
+    }
+    if (c <= 0x10FFFF)
+    {
+        assert(isValidDchar(c));
+        buf[0] = cast(char)(0xF0 | (c >> 18));
+        buf[1] = cast(char)(0x80 | ((c >> 12) & 0x3F));
+        buf[2] = cast(char)(0x80 | ((c >> 6) & 0x3F));
+        buf[3] = cast(char)(0x80 | (c & 0x3F));
+        return 4;
+    }
+
+    assert(!isValidDchar(c));
+    c = replacementDchar;
+    goto L3;
+}
+
+
+
+private bool isValidDchar(dchar c) pure nothrow @safe @nogc
+{
+    return c < 0xD800 || (c > 0xDFFF && c <= 0x10FFFF);
+}
+
 // technically s is octets but meh
 package string encodeUriComponent(string s) {
 	char[3] encodeChar(char c) {

minigui.d

@@ -1638,31 +1638,31 @@ class Widget : ReflectableProperties {
 
 	private bool showing_ = true;
 	///
-	bool showing() { return showing_; }
+	bool showing() const { return showing_; }
 	///
-	bool hidden() { return !showing_; }
+	bool hidden() const { return !showing_; }
 	/++
 		Shows or hides the window. Meant to be assigned as a property. If `recalculate` is true (the default), it recalculates the layout of the parent widget to use the space this widget being hidden frees up or make space for this widget to appear again.
+
+		Note that a widget only ever shows if all its parents are showing too.
 	+/
 	void showing(bool s, bool recalculate = true) {
-		auto so = showing_;
+		if(s != showing_) {
-		showing_ = s;
+			showing_ = s;
-		if(s != so) {
+			// writeln(typeid(this).toString, " ", this.parent ? typeid(this.parent).toString : "null", " ", s);
-			version(win32_widgets)
+
-			if(hwnd)
+			showNativeWindowChildren(s);
-				ShowWindow(hwnd, s ? SW_SHOW : SW_HIDE);
 
 			if(parent && recalculate) {
 				parent.queueRecomputeChildLayout();
 				parent.redraw();
 			}
 
-			foreach(child; children)
+			if(s) {
-				child.showing(s, false);
+				queueRecomputeChildLayout();
-
+				redraw();
+			}
 		}
-		queueRecomputeChildLayout();
-		redraw();
 	}
 	/// Convenience method for `showing = true`
 	@scriptable
@@ -1675,6 +1675,30 @@ class Widget : ReflectableProperties {
 		showing = false;
 	}
 
+	/++
+		If you are a native window, show/hide it based on shouldShow and return `true`.
+
+		Otherwise, do nothing and return false.
+	+/
+	protected bool showOrHideIfNativeWindow(bool shouldShow) {
+		version(win32_widgets) {
+			if(hwnd) {
+				ShowWindow(hwnd, shouldShow ? SW_SHOW : SW_HIDE);
+				return true;
+			} else {
+				return false;
+			}
+		} else {
+			return false;
+		}
+	}
+
+	private void showNativeWindowChildren(bool s) {
+		if(!showOrHideIfNativeWindow(s && showing))
+			foreach(child; children)
+				child.showNativeWindowChildren(s);
+	}
+
 	///
 	@scriptable
 	void focus() {
@@ -1752,8 +1776,12 @@ class Widget : ReflectableProperties {
 
 		w.addedTo(this);
 
-		if(this.hidden)
+		bool parentIsNative;
-			w.showing = false;
+		version(win32_widgets) {
+			parentIsNative = hwnd !is null;
+		}
+		if(!parentIsNative && !showing)
+			w.showOrHideIfNativeWindow(false);
 
 		if(parentWindow !is null) {
 			w.attachedToWindow(parentWindow);
@@ -4557,11 +4585,12 @@ class NestedChildWindowWidget : Widget {
 
 	}
 
-	override void showing(bool s, bool recalc) {
+	override bool showOrHideIfNativeWindow(bool shouldShow) {
 		auto cur = hidden;
-		win.hidden = !s;
+		win.hidden = !shouldShow;
-		if(cur != s && s)
+		if(cur != shouldShow && shouldShow)
 			redraw();
+		return true;
 	}
 
 	/// OpenGL widgets cannot have child widgets. Do not call this.
@@ -7216,7 +7245,6 @@ class PageWidget : Widget {
 				child.hide();
 			}
 	}
-
 }
 
 /++
@@ -12589,8 +12617,8 @@ class TextDisplayHelper : Widget {
 			doStateCheckpoint();
 
 			char[4] buffer;
-			import std.utf; // FIXME: i should remove this. compile time not significant but the logs get spammed with phobos' import web
+			import arsd.core;
-			auto stride = encode(buffer, ce.character);
+			auto stride = encodeUtf8(buffer, ce.character);
 			l.selection.replaceContent(buffer[0 .. stride]);
 			l.selection.setUserXCoordinate();
 			adjustScrollbarSizes();