Project cleanup

build.bat

@@ -1,28 +1,28 @@
 del /f containers\src\std\allocator.d
 
 dmd^
- client.d^
- messages.d^
- stupidlog.d^
+ src\client.d^
+ src\messages.d^
+ src\stupidlog.d^
  msgpack-d/src/msgpack.d^
  -Imsgpack-d/src^
  -release -inline -O -wi^
  -ofdcd-client
 
 dmd^
- actypes.d^
- conversion/astconverter.d^
- conversion/first.d^
- conversion/second.d^
- conversion/third.d^
- autocomplete.d^
- constants.d^
- messages.d^
- modulecache.d^
- semantic.d^
- server.d^
- stupidlog.d^
- string_interning.d^
+ src\actypes.d^
+ src\conversion/astconverter.d^
+ src\conversion/first.d^
+ src\conversion/second.d^
+ src\conversion/third.d^
+ src\autocomplete.d^
+ src\constants.d^
+ src\messages.d^
+ src\modulecache.d^
+ src\semantic.d^
+ src\server.d^
+ src\stupidlog.d^
+ src\string_interning.d^
  libdparse/src/std/d/ast.d^
  libdparse/src/std/d/entities.d^
  libdparse/src/std/d/lexer.d^

libdparse

@@ -1 +1 @@
-Subproject commit a91eb13e38a8560b9dda025b1c8ea837018e8252
+Subproject commit a9cbecbba471a08aa61f8e7aa844b4d0aae73262

makefile

@@ -9,9 +9,17 @@ DMD = dmd
 GDC = gdc
 #LDC = ldc
 
-CLIENT_SRC = client.d\
-	messages.d\
-	stupidlog.d\
+report:
+	dscanner --report src > dscanner-report.json
+	sonar-runner
+
+clean:
+	rm -rf bin
+	rm -f dscanner-report.json
+
+CLIENT_SRC = src/client.d\
+	src/messages.d\
+	src/stupidlog.d\
 	msgpack-d/src/msgpack.d
 
 DMD_CLIENT_FLAGS = -Imsgpack-d/src\
@@ -20,26 +28,26 @@ DMD_CLIENT_FLAGS = -Imsgpack-d/src\
 	-inline\
 	-O\
 	-wi\
-	-ofdcd-client
+	-ofbin/dcd-client
 
 GDC_CLIENT_FLAGS =  -Imsgpack-d/src\
 	-O3\
 	-frelease\
-	-odcd-client
+	-obin/dcd-client
 
-SERVER_SRC = actypes.d\
-	conversion/astconverter.d\
-	conversion/first.d\
-	conversion/second.d\
-	conversion/third.d\
-	autocomplete.d\
-	constants.d\
-	messages.d\
-	modulecache.d\
-	semantic.d\
-	server.d\
-	stupidlog.d\
-	string_interning.d\
+SERVER_SRC = src/actypes.d\
+	src/conversion/astconverter.d\
+	src/conversion/first.d\
+	src/conversion/second.d\
+	src/conversion/third.d\
+	src/autocomplete.d\
+	src/constants.d\
+	src/messages.d\
+	src/modulecache.d\
+	src/semantic.d\
+	src/server.d\
+	src/stupidlog.d\
+	src/string_interning.d\
 	libdparse/src/std/d/ast.d\
 	libdparse/src/std/d/entities.d\
 	libdparse/src/std/d/lexer.d\
@@ -65,27 +73,31 @@ DMD_SERVER_FLAGS = -Icontainers/src\
 	-O\
 	-release\
 	-inline\
-	-ofdcd-server
+	-ofbin/dcd-server
 
 GDC_SERVER_FLAGS =  -Imsgpack-d/src\
 	-Ilibdparse/src\
 	-O3\
 	-frelease\
-	-odcd-server
+	-obin/dcd-server
 
 dmdclient:
+	mkdir -p bin
 	rm -f containers/src/std/allocator.d
 	${DMD} ${CLIENT_SRC} ${DMD_CLIENT_FLAGS}
 
 dmdserver:
+	mkdir -p bin
 	rm -f containers/src/std/allocator.d
 	${DMD} ${SERVER_SRC} ${DMD_SERVER_FLAGS}
 
 gdcclient:
+	mkdir -p bin
 	rm -f containers/src/std/allocator.d
 	${GDC} ${CLIENT_SRC} ${GDC_CLIENT_FLAGS}
 
 gdcserver:
+	mkdir -p bin
 	rm -f containers/src/std/allocator.d
 	${GDC} ${SERVER_SRC} ${GDC_SERVER_FLAGS}
 

sonar-project.properties

@@ -0,0 +1,5 @@
+sonar.projectKey=dcd
+sonar.projectName=DCD
+sonar.projectVersion=1.0
+sonar.sourceEncoding=UTF-8
+sonar.sources=.

src/conversion/first.d

@@ -121,7 +121,7 @@ final class FirstPass : ASTVisitor
 			CompletionKind.functionName, symbolFile, dec.name.index,
 			dec.returnType);
 		processParameters(symbol, dec.returnType, symbol.acSymbol.name,
-			dec.parameters, dec.comment);
+			dec.parameters);
 		symbol.protection = protection;
 		symbol.parent = currentSymbol;
 		symbol.acSymbol.doc = internString(dec.comment);
@@ -512,7 +512,7 @@ private:
 	{
 		SemanticSymbol* symbol = allocateSemanticSymbol("*constructor*",
 			CompletionKind.functionName, symbolFile, location);
-		processParameters(symbol, null, "this", parameters, doc);
+		processParameters(symbol, null, "this", parameters);
 		symbol.protection = protection;
 		symbol.parent = currentSymbol;
 		symbol.acSymbol.doc = internString(doc);
@@ -543,7 +543,7 @@ private:
 	}
 
 	void processParameters(SemanticSymbol* symbol, const Type returnType,
-		string functionName, const Parameters parameters, string doc)
+		string functionName, const Parameters parameters)
 	{
 		if (parameters !is null)
 		{